From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id B51A93858D20 for ; Tue, 27 Feb 2024 17:27:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B51A93858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B51A93858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709054869; cv=none; b=r+JvnJ2R3xYc60uqVdtGOfF8i9JxFFBrKjc+Zt4qalVhA1cOlQj2ewC7i+cHLazzmfmQpdNugP1qCUnJ4u4v73AAR/O2lnPXxS7YHIZ/iN/h/XcHB2JinLwGQLOkCutmei3kbU6A8/RJj+XMT6U5iyQ4lb093ydv28YdmjPgDn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709054869; c=relaxed/simple; bh=nrosSOgq6hj7Q8gmDl3ZJC5S3ErlBrcLmlX/F1R/9qI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=w+nO79PTT7023GU20RlrP8781TtEM385PBz/RKjYwyLeSuyRufH7d31NanpVKDjVMHZHU8xcjZLQ//88SnNeeZWY5KV591Y7D93bBu+GKZz67b+r4uBAg++1IgTDutqViz/rhawztA2/SwmiQ7qd2hB3gM+4pB7PqfTYMrXQwQc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7c7b9b25ba6so90410739f.1 for ; Tue, 27 Feb 2024 09:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1709054867; x=1709659667; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1ntkk/1eFQ5wPHOtvR4162Xrz+cGXMtJIc/P8Qd8XUc=; b=bzOL3s0cloxBQU3SF98/Qr/PLCByzVguQVB5EqDJlIQVY4jfTxCSYcyxF0XvL2Ugrz ULZ3owfNsgBchSk6XFH+6M4dQ0+8aMD/QXTBwyHxGGaQEFLMZAk0LcEByJ4pCigRvdQG 5Xm36fGPvh0IOHgY3nJdtqkIVFhuZl24LpYD3f58CwqlI0oAYGkqzv8VG0Fn9eavWir5 XKu3bt0SQ2M67eZH2Peq0xHooyA/BmbwcWVKTcakcoLm9XBqYCnhaGtnHwylNKB7XBMJ RRRFJtg63j7ydY2pFLFBOHFRpNifzf+s0RLjs3xhWFCNFH2LGFnTKcDZo5mhQw8k4xB2 a62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709054867; x=1709659667; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1ntkk/1eFQ5wPHOtvR4162Xrz+cGXMtJIc/P8Qd8XUc=; b=E44GdkIbC5IrkwDuh75epwzpi05OsN+ffBSNqV10M/38Le87kR3aKzerNQFxG07meh OlPqqZZ9ASWwVnMtCVoY6VslVaDJ0SiNzfopnxeDm65oyadDaoERlQMZ4RnLn0AN4tix WdGrQRR3OhzfwiMISAoxkw28EFWEh8N1JFO7YkGfLbQ853ckfzMeWPd+R7fdIBnctuu9 mAZ3xHBfxtKHSgkbh1jfScwtEotNnSyc8MUuX8peWYznFHJNhCayJKED2Sncvvt6NbyE KdPdTTqFRLoheVGAoBvvcvbEfAfGf+kpkXd7Ceo+lnkzy0OvmOnHr6iikdhNpbMqpCDi bCdA== X-Forwarded-Encrypted: i=1; AJvYcCVoxl8hhoE0HRq/7VEJEZQlBdkZqrc7I+rtjqWz/CG0eS/Zlv9NxNju0a0c19XmQA8tKgvvk0NXuFE4JvXhIXFLL0RfIbRplkgpag== X-Gm-Message-State: AOJu0YyVaEePiYkmD0ibq0uzAGc9KlTssa7WlBnuJjGCxVBdlmOdDnM/ jcd7QKznmCsYxjnes0tx9gx82bX8wv+rLbcPWjYc7pQKlMniKJAs/rF7E53ZZAGZ026oXikb1aQ = X-Google-Smtp-Source: AGHT+IGaF8gklRR3Fg/16qqLJUUtFONa4U5hI4zWQu3o7p5t6JZ2hGnL64yQYhfMgv+J/NnLgIVcaw== X-Received: by 2002:a6b:e41a:0:b0:7c7:ead3:d8a0 with SMTP id u26-20020a6be41a000000b007c7ead3d8a0mr1959904iog.2.1709054866957; Tue, 27 Feb 2024 09:27:46 -0800 (PST) Received: from murgatroyd (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id w1-20020a5d8441000000b007c795591adcsm1820347ior.31.2024.02.27.09.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:27:46 -0800 (PST) From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] Rewrite final cleanups References: <20240223-final-cleanups-v1-0-84d5271e9979@adacore.com> <20240223-final-cleanups-v1-1-84d5271e9979@adacore.com> <20240225223034.l6gnzbamvivyzuyu@octopus> <87msrnvyz4.fsf@tromey.com> <20240227140331.cavxavrv4uoz4cdr@octopus> X-Attribution: Tom Date: Tue, 27 Feb 2024 10:27:46 -0700 In-Reply-To: <20240227140331.cavxavrv4uoz4cdr@octopus> (Lancelot SIX's message of "Tue, 27 Feb 2024 14:03:31 +0000") Message-ID: <87edcxvmul.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Lancelot> My train of thought was Lancelot> 1) This `system ("rm -rf ...")` could be replaced with Lancelot> std::filesystem::remove_all Lancelot> 2) At least one overload of remove_all can throw Lancelot> 3) What would happen if a cleanup throws (either an existing one, or one Lancelot> to change/introduce in the future). Makes sense. I filed a bug for this: https://sourceware.org/bugzilla/show_bug.cgi?id=31420 ... and also a C++17 meta-bug, and various C++17 to-do items I've thought of in the past. Lancelot> FWIW, I skimmed through the rest of the series, and looks reasonable to Lancelot> me. Thanks. Normally I would not rush this, but the current state of the tree is preventing us from doing a merge here at AdaCore, as DAP exiting is currently broken. So, I am going to check this in. Tom