From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id E19CD3858000 for ; Tue, 13 Feb 2024 18:08:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E19CD3858000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E19CD3858000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707847729; cv=none; b=T4iyKdGFwYgwaG3Gq6LHxzOALRpogyF7cWUJ30TsB3K+pVgG5v6xQvFO/rahXvcK0iDSUT9iwFc/lCgcAXEnZ/5TN25hwWbewboptxLpcQ7zxJ5atg8hOwGUwEDg58cN8X8hHzl9JsvPkoV45wBhA996Qwi0UymMa5Fn3hxa6Pc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707847729; c=relaxed/simple; bh=c+eF+Z/yYnI9L4irZeiDYOvczqKoXTvuZztmlTbYaOU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JSI4zkjt3gA1aPyTNI8RqPInFNfcT6wiNg5Sut5SBkJEHUh7BZYHlWHc/n1q1RQydt4RM4BXV+WP26dVRJfpduznrpHb8q+T9YwBHTO5zsbOi8B56IwLMflgPnt9F2kOxn++1XhjaLrEDiLrXR4DL61eCCsh7jx2t3QmHnJrkjE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id Zv4VrF0bLpUFLZxD5r8OtW; Tue, 13 Feb 2024 18:08:47 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ZxD4rlylkMfTTZxD4rtrsd; Tue, 13 Feb 2024 18:08:46 +0000 X-Authority-Analysis: v=2.4 cv=c+4IQg9l c=1 sm=1 tr=0 ts=65cbb02e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=NE5mf-L4L8S4lgQIhMIA:9 a=zgiPjhLxNE0A:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WcpATkfNsLQ0m2fcekZFL9qB6+jlXQv1DkGs8CF/d8c=; b=D8tah12e0LQTa0ZZUu7DoajCea LpeRjdi7ZcIWxaBkx/W0LNEHgxSchptYkekbGocwqUcJY/BFR0d2Z3M4OdvLFCd2PYS7ziWBPsVkr NbXFj+4OcVE83vU3zvSYs9h5F; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:47956 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rZxD3-002IHK-30; Tue, 13 Feb 2024 11:08:45 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] [gdb/testsuite] Fix another fail and tcl error in gdb.dap/sources.exp References: <20240213161823.25945-1-tdevries@suse.de> X-Attribution: Tom Date: Tue, 13 Feb 2024 11:08:45 -0700 In-Reply-To: <20240213161823.25945-1-tdevries@suse.de> (Tom de Vries's message of "Tue, 13 Feb 2024 17:18:23 +0100") Message-ID: <87eddg5j9u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rZxD3-002IHK-30 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net (murgatroyd) [71.211.170.195]:47956 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCCBGb9qkmCTRwH4b6+kE7wQVju0H1vFbJEz9Xk2TpjcjrPd4SiETD1Grunm1vBAK6l0JU72/GsBq/ZHBgD9uJQ0cleZ57s2pfBLtc5TZvE4PVy3GNYr uILYdgewXKsLkE1kHdzQYPTK/4NpsB13X+LrhVsdortEiSrzkOCRr9YmQK3UqPcTT56YBQe7+v7Q/Xn6tWVQ+8EFfyIs9d6x95Y= X-Spam-Status: No, score=-3015.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> These are the same type of tcl error and FAIL I just fixed for a later Tom> request in the same test-case. Tom> Fix this by: Tom> - moving the wait-for-stop to before the loadedSources request to fix the Tom> FAIL, and Tom> - checking for $obj == "" to fix the tcl error. This is fine as long as these tests are actually being run in the end. What I mean is, it would be bad to cover up a real failure of some kind. Approved-By: Tom Tromey Tom