Re: [PATCH v2] remote.c: Make packet_check_result return a structure

[Tom Tromey <tom@tromey.com>]

>>>>> "Alexandra" == Alexandra Hájková <ahajkova@redhat.com> writes:

Alexandra> +  packet_result (enum packet_status status, std::string err_msg):
Alexandra> +    m_status (status), m_err_msg (std::move (err_msg))

gdb normally puts the ":" on the next line.

Alexandra> +  const char *err_msg () const
Alexandra> +    {
Alexandra> +      gdb_assert (this->m_status == PACKET_ERROR);

Braces are indented too much here.

Alexandra>        if (buf[0] == 'E' && buf[1] == '.')
Alexandra> -	return PACKET_ERROR;
Alexandra> +      {
Alexandra> +	return { PACKET_ERROR, buf + 2 };
Alexandra> +      }

Braces look like they aren't indented properly here.
However I don't think those outer braces are needed at all since they
only wrap a return statement.

Tom