From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A788C3858028 for ; Mon, 18 Dec 2023 19:00:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A788C3858028 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A788C3858028 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702926029; cv=none; b=JCpZdvIq0qe4byExmq4dCBkaEsgP477RAopBKLGWfgBwsC6Pri5c3no17WM1g4X4FUlpRM0FICkjCTTdP7a23WVfwxKZ8V8vLA7VvRii2J8m/511c+kkFcWSABvT3KPTauZTuwVbNpLONA0D0KKt97xOzHRIx+9wHkRzzo8mIKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702926029; c=relaxed/simple; bh=ztj3FyRX4WgKuDI6lPHIlmeKX58jAhFm/sbVpqt24v4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rhFskqi9XyaCqyr2kfT9rn5ZdBZi3QH2gqQKOIWKCudoHj5Lkeo5dk/4mAsm71fxcZ4QfIqUcOIKuYXU+iwkpP6GY6lv3CQnsLBfUljGeYD3T4zfK/lecGoEGb6kJVy69Q7V9C93SLr2VvosvW7SvAKzlX2sxbqomkv7mA7CXmg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702926028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I8/sksb2vIuiv0iladowr9OamajJIF1oB+Ql4a3X4hk=; b=WwvVdy5vsSZEde1wZkePyXoyBNKboXH49nlzmu/CgVJCNXz13/2UdyrhuvSXPhaqDEKXDJ 3AmadanwRsWnMB2MBzjVFyLCdNM6ddKOI36ysj4DozgMJVX2nPQ7E2R5xotRfPZnoeJEL1 TgVdYAKSE5jtwLl6yajs06IF23b+/no= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-SPHl14WJMN-pZEIKWZkwBQ-1; Mon, 18 Dec 2023 14:00:27 -0500 X-MC-Unique: SPHl14WJMN-pZEIKWZkwBQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40c58a71b7cso32455665e9.2 for ; Mon, 18 Dec 2023 11:00:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702926023; x=1703530823; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I8/sksb2vIuiv0iladowr9OamajJIF1oB+Ql4a3X4hk=; b=W55OA64Nv3d5Bl6P3mBuYbzh9Ffmt4jZcsd8ttOPkKteEuBEcVswPQJfz5c4TJneF8 Ejqo6X7zxoMV0s6KV9YbKLOCJuab6yykJt4AyhvXXLTTrIAvApmTAFpTEJbgUuERVCwJ PRNYPDWFe2muiRI6yaXeMLr5MVLixcCAdgwlnRddok1EGnc/ZSdjL9WveYD0ED4KD+kS GVFcaizOzVHitGQcnnIDtdxgF73go9BCNoGlWHyI0ZHF+CdQxGXJ+I6yREaosgCLE4Rn ECkQcPuA/jSmyTviJcpnYn6KscxtPP1b5SlZbcXSaULXZpwn2mTj4RDYxb+a1IFyxSlh RGcg== X-Gm-Message-State: AOJu0YzcAwjV5FjTbH2L3M1FuX5txOkqRd9/1IUqW7/eGUtwWWCuOfZ3 sFiJFGs26RSryeqPYFb8WwXc2wGe/vY279+RvdlRQ2zPsD+4+yBUiyWWe9eiItYhZAUY6t1QzYe L24CSp4WFKq14TOnPCgWdjiIpMvB64w== X-Received: by 2002:a05:600c:4d1e:b0:40c:2987:17b9 with SMTP id u30-20020a05600c4d1e00b0040c298717b9mr9985362wmp.94.1702926023727; Mon, 18 Dec 2023 11:00:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+6AV//GGJY4wHrKEcH7MLp5CLA06Pf3GNJn5Y6hjhO8h0Y6Cf2cCQw0ixLiGRXq4Dk0AiXw== X-Received: by 2002:a05:600c:4d1e:b0:40c:2987:17b9 with SMTP id u30-20020a05600c4d1e00b0040c298717b9mr9985353wmp.94.1702926023403; Mon, 18 Dec 2023 11:00:23 -0800 (PST) Received: from localhost (92.40.185.142.threembb.co.uk. [92.40.185.142]) by smtp.gmail.com with ESMTPSA id vh9-20020a170907d38900b00a1d18c142eesm14443142ejc.59.2023.12.18.11.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 11:00:23 -0800 (PST) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 05/14] Remove tui_register_info::visible In-Reply-To: <20231217-tui-regs-cleanup-v1-5-67bd0ea1e8be@tromey.com> References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> <20231217-tui-regs-cleanup-v1-5-67bd0ea1e8be@tromey.com> Date: Mon, 18 Dec 2023 19:00:21 +0000 Message-ID: <87edfj49q2.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: > tui_register_info::visible is redundant with the fact that y==0 means > that the register is not visible -- and some spots already check the > latter. I'm not sure moving to 'y > 0' is an improvement though... Would a better solution be to change the visible to a member function, defined in the header file (so it can inline)? Thanks, Andrew > This patch removes this member in favor of having a single > indication of the register's visibility. This change makes it clear > that delete_data_content_windows is not needed, so this is removed as > well. > --- > gdb/tui/tui-regs.c | 15 +-------------- > gdb/tui/tui-regs.h | 1 - > 2 files changed, 1 insertion(+), 15 deletions(-) > > diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c > index f87d1ff8721..9108e460d6f 100644 > --- a/gdb/tui/tui-regs.c > +++ b/gdb/tui/tui-regs.c > @@ -269,7 +269,6 @@ tui_data_window::display_registers_from (int start_element_no) > /* Create the window if necessary. */ > m_regs_content[i].x = box_width () + (m_item_width * j); > m_regs_content[i].y = cur_y; > - m_regs_content[i].visible = true; > m_regs_content[i].rerender (handle.get (), m_item_width); > i++; /* Next register. */ > } > @@ -347,23 +346,13 @@ tui_data_window::first_data_item_displayed () > { > for (int i = 0; i < m_regs_content.size (); i++) > { > - if (m_regs_content[i].visible) > + if (m_regs_content[i].y > 0) > return i; > } > > return -1; > } > > -/* See tui-regs.h. */ > - > -void > -tui_data_window::delete_data_content_windows () > -{ > - for (auto &win : m_regs_content) > - win.visible = false; > -} > - > - > void > tui_data_window::erase_data_content (const char *prompt) > { > @@ -401,7 +390,6 @@ tui_data_window::rerender (bool toplevel) > else > { > erase_data_content (NULL); > - delete_data_content_windows (); > display_registers_from (0); > } > } > @@ -426,7 +414,6 @@ tui_data_window::do_scroll_vertical (int num_to_scroll) > { > first_line += num_to_scroll; > erase_data_content (NULL); > - delete_data_content_windows (); > display_registers_from_line (first_line); > } > } > diff --git a/gdb/tui/tui-regs.h b/gdb/tui/tui-regs.h > index 1a9f30fa270..701b8707947 100644 > --- a/gdb/tui/tui-regs.h > +++ b/gdb/tui/tui-regs.h > @@ -50,7 +50,6 @@ struct tui_register_info > /* The register number. */ > int regno; > bool highlight = false; > - bool visible = false; > std::string content; > }; > > > -- > 2.43.0