From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E71BE3858D20 for ; Thu, 14 Dec 2023 16:30:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E71BE3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E71BE3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702571403; cv=none; b=MmtdGqdXQJsR0XzvVg4024mWAmRPxOhaHVgIAe6Bda836lkkYlM3OS3xAzHFH7jl5RhWVxjjjklIEoW9AligzZBJvAVPX1RaebdmcEFAAo4LinmK5B4w2keD6zruGvZUIi8KeKAsgo00/UHJ8b53hmgoAGM4a+90Et4K9i3GtMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702571403; c=relaxed/simple; bh=y3ArV+JaWdRduY+z1B9dN2TeZiWwPpGLKeyqEGzhobw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=p5E1WykuOBi63Yj4G71uGCLcqUy5N7wCHKq2BnitBEjms34Y83Ky6njzHU9Ovwqe45vQYhuQvwdU53xqdL+YzvHmPfxSdMmgJIgP2iWGVeTiiKB8oOy/gEVjmcgpKR7dwHmEXAJ5tblxVtF7O7vNwvnHNWzg35sSb0Oqmm1Kaqo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702571401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VJdhejbg+oPKDyrN7QWQl40qdfmFLtWew97YR4KbpXs=; b=BiwP9bD9WAkvOxBNcwOY6P2E4QGSuaqmm0SFgOnMN4Ex+w7ZMTAgchrQX2zE6zlM/fewwE liwNI6G9K0gdhOhlHp4UL2ma7suJ7jDAN2tsxbQlic4vTQogpQzN3H1kM6lvH9vAbDYLfL moyhAI2+sjX0S+VMilI+L4q7YuUQPUY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-Cg8g6oD8Nrep6gMMjivHiw-1; Thu, 14 Dec 2023 11:30:00 -0500 X-MC-Unique: Cg8g6oD8Nrep6gMMjivHiw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3334549e36cso6189918f8f.0 for ; Thu, 14 Dec 2023 08:29:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702571399; x=1703176199; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VJdhejbg+oPKDyrN7QWQl40qdfmFLtWew97YR4KbpXs=; b=fbymcgmrwF+iwytBSIlcqec0UhM/ofT9YRMiqU0Tj28cdM473mfXznwmjQqG0uHYlX /6kGGUa334iEKy9+wISbUTcEU3vU75/SzUPiR5zG9COsXlr0ZuksBpYzbJOkgG45oUSp HRmIg/WNBCWeQOabr216aeIOcGCVez+EMI5C1nKcf8c7JNs0THII3y0QLnm3zPS/ebQp N17lhQQ4twSCgkrBxYuxFqxkf2f96l/Ox7f8CDyAhLFkYfXMEXkyeyXCgCOYsZQSHt2C lVXf0M5LuU5TrRPZeRHkBuP3NA/urDtxNHV6vE61r2OFaDIMwGWAs1M5crLT02L4TcjE xU2Q== X-Gm-Message-State: AOJu0YzKT8rHnrSq3AfHaw8qbGCgAAUI+d9wmt4mpL2nwly5M1hMUDUG F5aVyAXhL8j5sut6Ro6iwBDcJjMTHfzt9enPPkr0iNBc+9aKY64Lo2CdaA0NNzmceyDOMFu7VwH NXr773kE4ohTUYO/JPpNN5A== X-Received: by 2002:a05:6000:194f:b0:332:ce52:6388 with SMTP id e15-20020a056000194f00b00332ce526388mr4815949wry.14.1702571399065; Thu, 14 Dec 2023 08:29:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1NUjnP2ED9z2GL0BArt2ActWuZSwY7L3VJ+dLvYHma83kNusYEN8vhlYL6NgGIxjIlXKt3g== X-Received: by 2002:a05:6000:194f:b0:332:ce52:6388 with SMTP id e15-20020a056000194f00b00332ce526388mr4815946wry.14.1702571398723; Thu, 14 Dec 2023 08:29:58 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id v4-20020adff684000000b003364c47d75esm444787wrp.107.2023.12.14.08.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:29:58 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/options: fix copy&paste error in string_option_def In-Reply-To: <877clgaja1.fsf@tromey.com> References: <7d5ab0d95447c98d8581a94c1e1568dd44ffdf34.1702559691.git.aburgess@redhat.com> <877clgaja1.fsf@tromey.com> Date: Thu, 14 Dec 2023 16:29:57 +0000 Message-ID: <87edfoiw6y.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Spotted what appears to be a copy&paste error in string_option_def, > Andrew> the code for string handling writes the address fetching callback > Andrew> function into the option_def::var_address::enumeration location, > Andrew> rather than option_def::var_address::string. > > Andrew> Of course, this works just fine as option_def::var_address is a union, > Andrew> and all of its members are function pointers, so they're going to be > Andrew> the same size on every target GDB cares about. > > Andrew> But it doesn't hurt to be correct, so fixed in this commit. > > Looks good. Thank you. > Approved-By: Tom Tromey Pushed. Thanks, Andrew