From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 6FD0F3858CD1 for ; Mon, 11 Dec 2023 15:05:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FD0F3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FD0F3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702307127; cv=none; b=ZLBtBXJ2AZYzKeOGwNj5R+9n3U0MufTv594hNKgMlzeQM3qkevTqhtqS2aesGOELRnSaqIt5sjdxi3rGLhh8mdmHolQ2vLGoiBw/60AeIsuT7qP8yo8U2tT9Aar4CqEIM55RT1TJaPxtkNXGMJiUdmPXHwosS/P8QTverRHx/qY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702307127; c=relaxed/simple; bh=ecXSdXZ9SC88FASN9jzJuUKVG9g+6g72ox7JHz60mQQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=i5hmAtCYBLpJSscIazD3oAmG4exyDaODYBFZJ5gSiNr67MqN5zJNnUeTGGClgqQ1M/liMPwtDaEpn3JbXLCvRXOfZwXg11YOSUq1u0QDcuRJt6LJOAO5F8LMCRJaY/vUV/kST2ZZiwhfrspN9sX5wmEY99eRt82CuEl/47Pul1w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-35d4de84195so18939615ab.3 for ; Mon, 11 Dec 2023 07:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702307125; x=1702911925; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dcLk96AJ+vnr3AeA6Qstrjon8T198X5RAuTpD7I11ZA=; b=BniZOCnm0y0VgD5liwETldriPsaLW+fPDF004tpOKlehKEA6alWojnkPHGjdsu0pw5 3hQNlLQ/tpaU76rx1SSbkSWcUjQDZDPvIUHwva8F7jRUd9ObcrdlIQJvhxYbpWcOs3aE 7W/I7PwSdwf19JO9QWNP5h0RGAD+1/jvY4mBypFG6e2rMJBodekKYopJ6LIkHusce/NI 5PsWZoVfx8JFtwwCMYAtzSBnWFNrkOrBmbU0zXo0qBvtRlaFpuNMcXTmkOCpJYGWVQDQ BzR8d6CyNKi6cMQ3h81l1YaVoyRYXUaVSD3Qj6cz5hkfKgENf+UY/j0M8+u5wZIDWAI5 LPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702307125; x=1702911925; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dcLk96AJ+vnr3AeA6Qstrjon8T198X5RAuTpD7I11ZA=; b=HCeVl0gZ1SLLLvD6ldcSJ/tfaMdmGJciSrG1ORpCvg1p6lHhXB1JnhuaQNjKgwKXTM kN+mZWJ6YKM8zzvqECI9soIXTjvzhM65Yu36a73mXZB8s4zmSXid4CIcK/d9MESOvliI 1dK2MY9/aodunbzKKmj6WB5OgN8LC4nGBlAL9ya8ubonDCRD4UvN+mXgmf+nrMN7TAeL JXyM+JRbP/3OHtwTEWxL1TpIvmtL3x+QI7+oJVrs0g4WqM01VmiKO8heLso4SKuLkDUk EJDhSyx4LLtGFz7UJUl7cmrkZecNC1ESTizfP8/QkrcRhNGIaSMAfD4UD+/JRBD6UxiR 2owg== X-Gm-Message-State: AOJu0YzrELY3OgFLna8KacQvshJRsSmKPa8JuoxG0xgkshYCN2CkzCbp Fwnt85Z4txGhiXlqKWuG0cUt0A== X-Google-Smtp-Source: AGHT+IGA/L4MhqvIK/qjvj8mGYkwDuVMmnrp+CEtvd9Ms4/WFiNqVhuApFVGMffs0ferY2xT+XUIhg== X-Received: by 2002:a05:6e02:1a21:b0:35d:59a2:929c with SMTP id g1-20020a056e021a2100b0035d59a2929cmr5162469ile.48.1702307125684; Mon, 11 Dec 2023 07:05:25 -0800 (PST) Received: from murgatroyd (71-211-161-25.hlrn.qwest.net. [71.211.161.25]) by smtp.gmail.com with ESMTPSA id o8-20020a02c6a8000000b00469456346efsm1866147jan.95.2023.12.11.07.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 07:05:24 -0800 (PST) From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 6/6] Implement DAP cancellation References: <20231201-dap-cancel-v1-0-872022fc328a@adacore.com> <20231201-dap-cancel-v1-6-872022fc328a@adacore.com> <83cyvpapa1.fsf@gnu.org> X-Attribution: Tom Date: Mon, 11 Dec 2023 08:05:23 -0700 In-Reply-To: <83cyvpapa1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 01 Dec 2023 17:57:58 +0200") Message-ID: <87edfsg4p8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_XBL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Eli" == Eli Zaretskii writes: >> From: Tom Tromey >> Date: Fri, 01 Dec 2023 08:41:02 -0700 >> >> This implements DAP cancellation. A new object is introduced that >> handles the details of cancellation. While cancellation is inherently >> racy, this code attempts to make it so that gdb doesn't inadvertently >> cancel the wrong request. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30472 >> --- >> gdb/doc/gdb.texinfo | 16 +++++++ >> gdb/python/lib/gdb/dap/server.py | 91 ++++++++++++++++++++++++++++++++++++++-- >> gdb/testsuite/gdb.dap/pause.exp | 71 +++++++++++++++++++++++++++++++ >> 3 files changed, 175 insertions(+), 3 deletions(-) Eli> Thanks, the documentation part is OK. Eli> Reviewed-By: Eli Zaretskii Thanks. I realized I should start adding NEWS entries for DAP changes. Assuming the earlier one is approved: +* Debugger Adapter Protocol changes + + ** GDB now emits the "process" event. + ... then for this cancel patch I'd propose adding: ** GDB now supports the "cancel" request. Tom