From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] [gdb/tui] Don't include border_width in left_margin
Date: Mon, 13 Nov 2023 10:42:18 -0700 [thread overview]
Message-ID: <87edgtsg79.fsf@tromey.com> (raw)
In-Reply-To: <20231110130051.21239-3-tdevries@suse.de> (Tom de Vries's message of "Fri, 10 Nov 2023 14:00:51 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Currently left_margin does not match its documentation:
Tom> ...
Tom> /* Return the size of the left margin space, this is the space used to
Tom> display things like breakpoint markers. */
Tom> int left_margin () const
Tom> { return box_width () + TUI_EXECINFO_SIZE + extra_margin (); }
Tom> ...
Tom> It is stated that the left margin is reserved to display things, but
Tom> the box_width is not used for that.
Tom> Fix this by dropping box_width () from the left_margin calculation.
Makes sense to me. Thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-11-13 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 13:00 [PATCH 1/3] [gdb/tui] Refactor prefresh call in tui_source_window_base::refresh_window Tom de Vries
2023-11-10 13:00 ` [PATCH 2/3] [gdb/tui] Add tui_win_info::{box_width,box_size} Tom de Vries
2023-11-13 17:42 ` Tom Tromey
2023-11-10 13:00 ` [PATCH 3/3] [gdb/tui] Don't include border_width in left_margin Tom de Vries
2023-11-13 17:42 ` Tom Tromey [this message]
2023-11-13 17:41 ` [PATCH 1/3] [gdb/tui] Refactor prefresh call in tui_source_window_base::refresh_window Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edgtsg79.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).