From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 6B7243858D33 for ; Tue, 17 Oct 2023 20:07:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B7243858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B7243858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697573255; cv=none; b=DiM442VyfCTC6Qt0NLLWDglaJ8OK+Xos9H6IFstrbnFQiIiVO7gL9CNCTinJC6bhF1A6JVUA4H5aJQN4xp/XUuTEjCZV3NaebV5wbrQqA6H3hgq1IhmyRadgf3HBljQ4CiwwpQ517iM3sQZF8z9XCDqTI+0FOsQGi5SygulVLeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697573255; c=relaxed/simple; bh=eU9tl/LY3mtBlBkHbw2Ib54AVRCGKuCDW010X5EGjuc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=L4CQb7UxsgUcKr3G+LvXPjoyK4s4eZc3dyUESE+t3B3oXFytn4//DmejHdOJexj5GWNm4q0Gga/wXoTjKU1gYB52Umvzi+T1nPjUba83kPw+Ct1nUKHnfL0ePKJMM1gPtw0eqAXmben3XCmejMmU4pUheXUAVz24z8tXldekvlE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id sWfOqCiA2CPDcsqLjq5Iji; Tue, 17 Oct 2023 20:07:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id sqLiqXFUVCB5nsqLjqcBQH; Tue, 17 Oct 2023 20:07:31 +0000 X-Authority-Analysis: v=2.4 cv=BquOfKb5 c=1 sm=1 tr=0 ts=652ee983 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=MPfW18ZdOEWqFVrgssEA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eU9tl/LY3mtBlBkHbw2Ib54AVRCGKuCDW010X5EGjuc=; b=G527SIL/HrNghFAT9Pam0es05j fXDT1FO91vNgFilUh7zLdG2aIIKtrShYeXdiehRKV5pW2S7R8AbR/dpd0jUqzYNUlSlcXnOe0IjCa 6pq7ILC5LSAZWtE0bTMXE5wVf; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:55986 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qsqLi-0033Oe-1X; Tue, 17 Oct 2023 14:07:30 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] [gdb/symtab] Fix style issues in v9 .gdb_index section support References: <20231011153214.25769-1-tdevries@suse.de> X-Attribution: Tom Date: Tue, 17 Oct 2023 14:07:29 -0600 In-Reply-To: <20231011153214.25769-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 11 Oct 2023 17:32:13 +0200") Message-ID: <87edhtqagu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qsqLi-0033Oe-1X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:55986 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFrRoDugAa5NNVQuYZF9J8v/iqlIcd8oqWcDwNIbMN9r/uwTyKJmn+kKhJVAlE8IFl5obYxstvlSOWpdUhUT+JpjV+JIsHnbLzA9foqs+RisDgQjJISc /kXQuEDBV9IcQHEMfaye2qGQ9Hf6RmFXavCGWMDsKBASBWOb8LSK6EuKi4jFs9PsPqg1ZXp0KSTQ3I2HBwSWNNBUEJjk0Dx4q0M= X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Post-commit review pointed out a few style issues in commit 8b9c08eddac Tom> ("[gdb/symtab] Add name_of_main and language_of_main to the DWARF index"). Tom> Fix these. Tom> Tested on x86_64-linux. Thank you, this looks good. Approved-By: Tom Tromey I found a race in this code as well, I'm working on a fix for that though. Tom