From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id A82473858D28 for ; Fri, 13 Oct 2023 13:06:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A82473858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-35749556444so8055285ab.1 for ; Fri, 13 Oct 2023 06:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1697202372; x=1697807172; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=FhxNoa4PCI9wXvHStZL61+DRHEfYo1jJ1Io6zOxQOSg=; b=kMPcx7TVopP0kf4QCJQ202ev0l8CCWWsEuNaFbg2N7uNyeeud/WRXxlz+KZfquLlqE d/jMgXQ6rHbvziGw+P1Sz9Z1X7hybuIsH4w2yc+ZR/eI3qrAOCkcYQwR5YnX0iu8+9KQ 4pa5LJrgEkhC9z3QTrrxIWCgyN+3/V+LoUUqey0nDNyRGyzMrlXI0FrCBildAQ/50m7T TJBvCfM2rUgDWFadQnTAacltmnT8rxcgaIBEwx0q0wBy7uX564B/tSNIOMYsb5ZDLdop usRYZ3V/uPOooHp1kJiKxrUROdmHGrmeLO7hLaxfZ7qHvr4VEkaucJdSwvvA0aInlFlb lU5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697202372; x=1697807172; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FhxNoa4PCI9wXvHStZL61+DRHEfYo1jJ1Io6zOxQOSg=; b=LYYCQWJ51/us8cgGBal3MQAUXUdOslJ/y3j+S/Hc0qLNS41n4uC+B6WYzLw6qbaEMD KoJykea7A3rJnIhzrEevDGEk4lRJhADWvhkd2kfm0qqjOQgIjI5Rv91WALqXQFbtHfBl kiTj0htOQpEzcpT595Yi983mVosaRDYJMOq0cGsIxQRDOh6++4MeLvtY2xBFrNcy4Dbb Ak3Dx/xbcEVmxkkMtsiA1r3tmGonzU/QEFCSOTRsyRoCHcASRb9PSbtsfpfkGQShXOQ2 kBHVGDD9+eVH3sKWN+TYk/IwFczqRGOvq/BpqrjWLwTDEObkCZsPu529W1QYflVPEhra AZkw== X-Gm-Message-State: AOJu0Ywf4spbjVMoLdULYaN/z4L5EijdfI0Elc22/PuTplOhA3R2FK6s GzWtZHj0znjKITVy2kVqq2qMRQ== X-Google-Smtp-Source: AGHT+IG3Sf6ePaqKi/HJi6ENub8OLMucL9NRYNGJAk9CS/yszDDIuyDqnPm2SB0WFpx5LOqWHcvJ5A== X-Received: by 2002:a92:ca90:0:b0:352:a16b:7c0d with SMTP id t16-20020a92ca90000000b00352a16b7c0dmr27001ilo.14.1697202371769; Fri, 13 Oct 2023 06:06:11 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id b7-20020a92c147000000b0034f37a27bb4sm1387727ilh.72.2023.10.13.06.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 06:06:11 -0700 (PDT) From: Tom Tromey To: Luis Machado via Gdb-patches Cc: Luis Machado , thiago.bauermann@linaro.org Subject: Re: [PATCH v7 05/18] [gdb/aarch64] sme: Enable SME registers and pseudo-registers References: <20230918212651.660141-1-luis.machado@arm.com> <20230918212651.660141-6-luis.machado@arm.com> X-Attribution: Tom Date: Fri, 13 Oct 2023 07:06:10 -0600 In-Reply-To: <20230918212651.660141-6-luis.machado@arm.com> (Luis Machado via Gdb-patches's message of "Mon, 18 Sep 2023 22:26:38 +0100") Message-ID: <87edhyu0xp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Luis" == Luis Machado via Gdb-patches writes: Hi Luis. This patch caused a gdbserver build failure on aarch64-linux. In file included from ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-ptrace.h:36, from ../../src/gdbserver/linux-aarch64-low.cc:48: ../../src/gdbserver/linux-aarch64-low.cc: In function 'void aarch64_adjust_register_sets(const aarch64_features&)': ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:304:45: error: '__SVE_VQ_BYTES' was not declared in this scope; did you mean 'SVE_VQ_BYTES'? 304 | ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ | ^~~~~~~~~~~~~~ ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:325:10: note: in expansion of macro 'ZA_PT_ZA_OFFSET' 325 | (ZA_PT_ZA_OFFSET + ZA_PT_ZA_SIZE(vq)) | ^~~~~~~~~~~~~~~ ../../src/gdbserver/linux-aarch64-low.cc:941:28: note: in expansion of macro 'ZA_PT_SIZE' 941 | regset->size = ZA_PT_SIZE (features.svq); | ^~~~~~~~~~ CXX nat/aarch64-linux.o Luis> +/* Make sure we only define these if the kernel header doesn't. */ Luis> +#ifndef ZA_PT_SIZE ... Luis> +/* Offset from the start of struct user_za_header to the register data */ Luis> +#define ZA_PT_ZA_OFFSET \ Luis> + ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ Luis> + / __SVE_VQ_BYTES * __SVE_VQ_BYTES) Is it safe to just remove the "__" as the compiler suggests? thanks, Tom