From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=P0T2=C5=adacore.com=tromey@sourceware.org>
Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c])
	by sourceware.org (Postfix) with ESMTPS id A10B03858D20
	for <gdb-patches@sourceware.org>; Tue, 11 Jul 2023 13:17:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A10B03858D20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com
Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-6b5ef64bca6so4979024a34.3
        for <gdb-patches@sourceware.org>; Tue, 11 Jul 2023 06:17:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=adacore.com; s=google; t=1689081473; x=1691673473;
        h=mime-version:user-agent:message-id:in-reply-to:date:references
         :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=3ibcdAEu2xn2d03n0AgCbXwNbFUDetDn1b/A7n3jzAw=;
        b=OTlj0VS7mj7Nwj0NXeRxvj0eZ5+katrBVMSklUuShfudGuHqZ1ttwkkvBKUIcXMLwQ
         B1+mV/DyAjmWkOKUDmoIx8f8QHkVIytdK9IoJG19fqTdOPFP/46wtOuOT4vVL/K8cQwm
         7aZDJo0rlL7Q3RLckBIxmoqQn2mUyvsPsMHPnWbdB76iztxJ8QmiFGZAldebTUDB72dc
         ApTKCz+IofnCpb41N1myvrFplqDpLJh5oZPeRbuOdgU8/HysK/jL9dLtOmQFCnvDIQNI
         gxvqDI2Ll84iN8PSubJNENlyp4bMUyX23ZXeBxYZg33P4oImQgafffZJk82busSGV8M3
         VEIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1689081473; x=1691673473;
        h=mime-version:user-agent:message-id:in-reply-to:date:references
         :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=3ibcdAEu2xn2d03n0AgCbXwNbFUDetDn1b/A7n3jzAw=;
        b=TUibYETJF8nQ0/GH5dw9TNAKwjAstYCQ7w/ivtAmSC+2HyG+BJI7ImMy69M3Vxyj8t
         HR2bppyEUoliLrogkF39eRoIPclGwITgwYC8uwkhIh9jSKJm6uGi6GsbDB88onCRMbNH
         VCLFRhDvBx+okRf17UlUbw0lo5nsxC8yk3C92W0yd+xYlQjk69fZGiAP6lEN0rPixw40
         qbAhh19k2xQQUdButX5kVEL3eUrjkJZ6G82qKiOdh+Y1SowXQqTxpEIWJkCHDJAZxUeZ
         MMhKptrkCyGHI6Zq/IeweCF3IfV+mtUohvOlMAaHpFcNWeGQU7jwYkySYc7sFQXZNB5d
         jM/A==
X-Gm-Message-State: ABy/qLbEQXCr/9/l9+VSTQM1faKYxoEsrIo8PC2BAQnyOCIEYKoZSQhP
	9wpD3I6g89MiL6vYHe52W9DA+Q==
X-Google-Smtp-Source: APBJJlFyGtaQt+wi8f/M01C9+l9rgAuqjR4PVJPEqV5ZKcm/znQJuNGY0oQclBErnF6fmXYCa11JPA==
X-Received: by 2002:a9d:6e09:0:b0:6b9:5abf:4501 with SMTP id e9-20020a9d6e09000000b006b95abf4501mr5419971otr.10.1689081472947;
        Tue, 11 Jul 2023 06:17:52 -0700 (PDT)
Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140])
        by smtp.gmail.com with ESMTPSA id a18-20020a02ac12000000b0042ae260e5d7sm532151jao.57.2023.07.11.06.17.52
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 11 Jul 2023 06:17:52 -0700 (PDT)
From: Tom Tromey <tromey@adacore.com>
To: Bruno Larsen <blarsen@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove some TODOs from gdb.cp tests
References: <20230710162736.1695116-1-tromey@adacore.com>
	<5c00d866-efe2-16d6-b359-988fb26e4b35@redhat.com>
X-Attribution:  Tom
Date: Tue, 11 Jul 2023 07:17:51 -0600
In-Reply-To: <5c00d866-efe2-16d6-b359-988fb26e4b35@redhat.com> (Bruno Larsen's
	message of "Tue, 11 Jul 2023 12:34:21 +0200")
Message-ID: <87edler3i8.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

>> * exception.exp - the code relying on the line numbers can't work,
>> because gdb never prints that message anyway.

Bruno> If that is dead code, why not remove those and just have a simple gdb_test?

Yeah, I did do that, e.g.:

>> # Continue to second catch.
>> -set name "continue to second catch"
>> -gdb_test_multiple "continue" $name {
>> -    -re "Continuing.${ws}Catchpoint \[0-9\]+ \\(exception caught\\), throw location.*${srcfile}:30, catch location .*${srcfile}:58\r\n$gdb_prompt $" {
>> -	pass $name
>> -    }
>> -    -re "Continuing.${ws}Catchpoint \[0-9\]+ \\(exception caught\\).*\r\n$gdb_prompt $" {
>> -	pass $name
>> -    }
>> -}
>> +gdb_test "continue" \
>> +    "Continuing.${ws}Catchpoint \[0-9\]+ \\(exception caught\\).*" \
>> +    "continue to second catch"
>> # Backtrace from the catch point.
>> # This should get to user code.

Tom