From: Tom Tromey <tom@tromey.com>
To: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Farre <simon.farre.cx@gmail.com>
Subject: Re: [PATCH v1] gdb/dap - Getting thread names
Date: Tue, 13 Jun 2023 06:56:13 -0600 [thread overview]
Message-ID: <87edmf5xn6.fsf@tromey.com> (raw)
In-Reply-To: <20230613071023.7258-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Tue, 13 Jun 2023 09:10:23 +0200")
>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:
Thanks for the patch.
Simon> from .startup import send_gdb_with_response, in_gdb_thread
Simon> +def thread_name(thr):
It's a convention in the DAP code for internal functions to start with
"_", and also to have a descriptive comment. Also make sure you run
'black' on the patch (I suspect it would add another blank line before
the def, not sure though).
This is ok with those changes.
Tom
prev parent reply other threads:[~2023-06-13 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 7:10 Simon Farre
2023-06-13 12:56 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edmf5xn6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.farre.cx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).