From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCH] Remove parameter from select_source_symtab
Date: Sun, 07 May 2023 13:03:57 -0600 [thread overview]
Message-ID: <87edns55gi.fsf@tromey.com> (raw)
In-Reply-To: <7d2bc0ed-791a-4fc7-b4a8-4902ea2a278b@redhat.com> (Bruno Larsen via Gdb-patches's message of "Mon, 24 Apr 2023 17:45:32 +0200")
>>>>> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> On 17/04/2023 23:24, Tom Tromey wrote:
>> I noticed that select_source_symtab is only ever called with nullptr
>> as an argument, so this patch removes the parameter and associated
>> logic.
>> ---
> Looks alright to me!
> Reviewed-By: Bruno Larsen <blarsen@redhat.com>
Thanks, I'm checking it in.
Tom
prev parent reply other threads:[~2023-05-07 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 21:24 Tom Tromey
2023-04-24 15:45 ` Bruno Larsen
2023-05-07 19:03 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edns55gi.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).