From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2E83A3858D32 for ; Thu, 13 Apr 2023 09:25:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E83A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681377921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vnytyla9qlu8KWYoNWf9GA1QbN5RF/vgJBl43cf4Hq4=; b=OFsgbf0Q3/TdZTyo7L9rFLeFhrjjoMgsZjYeS84OZrBncED+DpYdiEMMkCSib92H/QnUgk dWr8IOF8XUWPS/2EsUoPuRg3P7CZ8djjVuyUsNjq9gQ17bzlph0t6ioOcw3cACENET4dZ/ S4gU+g0DT9pjwzotQ3sKJUHs76aACcA= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-rVpsNuiwOZGmXVEgJsYMnQ-1; Thu, 13 Apr 2023 05:25:20 -0400 X-MC-Unique: rVpsNuiwOZGmXVEgJsYMnQ-1 Received: by mail-ed1-f71.google.com with SMTP id i17-20020a50d751000000b005045c08ca6dso10723348edj.7 for ; Thu, 13 Apr 2023 02:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681377919; x=1683969919; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vnytyla9qlu8KWYoNWf9GA1QbN5RF/vgJBl43cf4Hq4=; b=Fc1RrRfO7nrHGMKWv62Xl8O1Z+PW3KdFOPjEHrflF/PRCOW+kk/KhstRXdpy3FQqpK YkuRN78sevIeWTBLyZEUOIcPQjgOcV+LQfme5u/ifplZeqvW/Cm/ZJh5U5O1/U4368k5 HggfGvmQvLU8B2xpCy53M042sHz+jXmq4dMStMe9STQgOZY5IaffpseXklrRuRYIkySD ZY7E149TXdwOdaXIt31Bh0CeH7ZEkRNdmDrUHd3rVJ/75AzTIGanPaf2WMbsZuaXB4De r7j/TmxSaL0PIqJRZbsAMb04I091+15sdE/stpM/0WU1hOHy/XbSc6KbAX+1LO113Ypu SWMA== X-Gm-Message-State: AAQBX9dwo8ePerv8x0hzzk+GCmLXB5Mmi/IOhJqvQas69lEAcNHCJv3J BREno8RAZ+/wFRe6WNlsZSPoIagEWlEun80L+pChPSztr9LHC3p9X5j027ZKUTGBRdH0eiBsdgX Q6Rcw8opM5mX3Dj8NCAW+lA== X-Received: by 2002:a17:906:318a:b0:94a:972d:451 with SMTP id 10-20020a170906318a00b0094a972d0451mr2047337ejy.67.1681377919569; Thu, 13 Apr 2023 02:25:19 -0700 (PDT) X-Google-Smtp-Source: AKy350YW+rRtWFuXL6vXnukFNURN2pUSoHBoLEWQLN5Y82QbzItCF480dkEzAVdBBjVe6e5n28997Q== X-Received: by 2002:a17:906:318a:b0:94a:972d:451 with SMTP id 10-20020a170906318a00b0094a972d0451mr2047324ejy.67.1681377919318; Thu, 13 Apr 2023 02:25:19 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id e22-20020a170906249600b0094bffd6e1e6sm671373ejb.204.2023.04.13.02.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 02:25:18 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 2/3] [gdb/tui] Fix left margin in disassembly window In-Reply-To: <87ile09mdg.fsf@redhat.com> References: <20230411082332.25052-1-tdevries@suse.de> <20230411082332.25052-2-tdevries@suse.de> <87leiwak03.fsf@redhat.com> <8de9c7c9-5d88-0923-403d-c291a8d64340@suse.de> <87ile09mdg.fsf@redhat.com> Date: Thu, 13 Apr 2023 10:25:17 +0100 Message-ID: <87edoo9ls2.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: > Tom de Vries writes: > >> On 4/12/23 23:06, Andrew Burgess wrote: >>> I'm surprised there's no new test for this. I kind of assumed the new >>> maint command (from patch #1) was to make writing the test easier... >>> >> >> It certainly could be used for that, yes. My primary purpose though was >> to make the problem easily visible. >> >> I haven't added a test because I'm still fixing issues I find with the >> current testsuite... >> >> I might add a test-case for this eventually, or hijack one of the >> existing tests. > > I don't understand -- aren't you proposing this patch for inclusion now? > > Patches should be accompanied by a corresponding test. > > I really think this should have a test before it's merged. Oh, I just noticed you merged this anyway. GDB development is usually done by consensus. That would mean if someone raises a concern -- like a test is missing -- then you don't merge a patch until the concern has been discussed and addressed. I've had plenty of patches on the list that have had an approval, and then a concern raised by someone else. I don't just choose to see the approval and merge the patch regardless -- that's just disrespectful to a pretty legitimate concern I had about this patch. I know writing tests can be a real drag, but it really is critical to making GDB a solid product. Hopefully you can prioritise getting a test written for this patch. Thanks, Andrew