From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 1FE683858407 for ; Mon, 27 Feb 2023 18:10:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FE683858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 3B2F41004BB7B for ; Mon, 27 Feb 2023 18:10:26 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id WhxCpNs6HuVTuWhxCpRay6; Mon, 27 Feb 2023 18:10:26 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=UcqU9IeN c=1 sm=1 tr=0 ts=63fcf212 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=pyJB9jFZkOOsZLKgtJAA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5wbPcRb2ubjoZJ4b+88NsINSrGdDnXHrr5ALBO7A6LQ=; b=UqRPFW7IJTsUv2W+4pUAZ9HVfh vK4UCxGMJ0zr9stPmqhgD5V/7bNJGFsICaueqsbHHCMoHp0M6CCyUDknUlEKsY13b2nlQrSHHKtFK jXGORZWJjHkYETQJwuw0wfud7; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:57446 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pWhxB-001OoL-RC; Mon, 27 Feb 2023 11:10:25 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: add HtabPrinter to gdb-gdb.py.in References: <20230209195056.100681-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 27 Feb 2023 11:10:22 -0700 In-Reply-To: <20230209195056.100681-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 9 Feb 2023 14:50:56 -0500") Message-ID: <87edqbdlo1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pWhxB-001OoL-RC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:57446 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> When debugging GDB, I find it a bit tedious to inspect htab_t objects. Simon> It is possible to find the entries by poking at the fields, but it's Simon> annoying to do each time. I think a pretty printer would help. Add a Simon> basic one to gdb-gdb.py. I could have used this today :-} Simon> + def _children_generator(self): Simon> + size = int(self._val["size"]) Simon> + entries = self._val["entries"] Simon> + Simon> + child_i = 0 Simon> + for entries_i in range(size): Simon> + entry = entries[entries_i] Simon> + # 0 (NULL pointer) means there's nothing, 1 (HTAB_DELETED_ENTRY) Simon> + # means there was something, but is now deleted. Simon> + if int(entry) in (0, 1): Simon> + continue Simon> + Simon> + yield (str(child_i), entry) Simon> + child_i += 1 Simon> + Simon> + def children(self): Simon> + return self._children_generator() I don't think the indirection here is needed, you can just have children yield. But, either way seems fine to me. Reviewed-By: Tom Tromey Tom