From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 74ADC3858431 for ; Tue, 14 Feb 2023 15:54:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74ADC3858431 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id C6E3E10047FAE for ; Tue, 14 Feb 2023 15:54:38 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Rxdep3coIFh3zRxdepTUiC; Tue, 14 Feb 2023 15:54:38 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QpabYX+d c=1 sm=1 tr=0 ts=63ebaebe a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=Oww4CGEEvnVY2vQMtJkA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=II88WHzNpfmgcvY4cDf/9tYug1oVj6YgzCarX+b1IeY=; b=ljVOBTrQyMAsjqZvmgXZ/l1ePU p4BkW9/WCFDW46UQCdMIZZ2Bpx7l6M7ym26BLq+E+5UZKdpEmd4V7nMOgG0TTZ/GKG9/Soq4bik+R Z9w6pZ+aYHvVAhIghajGYBzSI; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:42718 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRxde-003EQV-D4; Tue, 14 Feb 2023 08:54:38 -0700 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 6/6] Don't throw quit while handling inferior events, part II References: <20230210233604.2228450-1-pedro@palves.net> <20230210233604.2228450-7-pedro@palves.net> X-Attribution: Tom Date: Tue, 14 Feb 2023 08:54:34 -0700 In-Reply-To: <20230210233604.2228450-7-pedro@palves.net> (Pedro Alves's message of "Fri, 10 Feb 2023 23:36:04 +0000") Message-ID: <87edqstf7p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRxde-003EQV-D4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:42718 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: Pedro> I noticed that if Ctrl-C was typed just while GDB is evaluating a Pedro> breakpoint condition in the background, and GDB ends up reaching out Pedro> to the Python interpreter, then the breakpoint condition would still Pedro> fail, like: Pedro> The fix is to disable cooperative SIGINT handling while handling Pedro> inferior events, so that SIGINT is saved in the global quit flag, and Pedro> not in the extension language, while handling an event. I wonder if there's an open PR about this. It sounds vaguely familiar. Thanks for doing this, and for the very clear comments. Approved-By: Tom Tromey Tom