From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb: add test for readline handling very long commands
Date: Fri, 10 Feb 2023 07:35:37 -0700 [thread overview]
Message-ID: <87edqxziyu.fsf@tromey.com> (raw)
In-Reply-To: <5590ca7146d94722f6ae6b2e96fe92f3ef6b4eab.1676025758.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 10 Feb 2023 10:42:46 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> The test added in this commit tests for a long fixed readline issue
Andrew> relating to long command lines. A similar patch has existed in the
Andrew> Fedora GDB tree for several years, but I don't see any reason why this
Andrew> test would not be suitable for inclusion in upstream GDB. I've
Andrew> updated the patch to current testsuite standards.
It seems fine to me.
Reviewed-By: Tom Tromey <tom@tromey.com>
Andrew> I recreated the above crash by a little light hacking on GDB, and then
Andrew> linking GDB against readline 5.2.
OMG.
Tom
next prev parent reply other threads:[~2023-02-10 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 10:42 Andrew Burgess
2023-02-10 14:35 ` Tom Tromey [this message]
2023-02-11 17:18 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edqxziyu.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).