From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 03BAD3858D32 for ; Sat, 21 Jan 2023 17:09:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03BAD3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 05BD110048199 for ; Sat, 21 Jan 2023 17:09:45 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id JHNApJY3hiOW0JHNBp8yO4; Sat, 21 Jan 2023 17:09:45 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=S5kcfKgP c=1 sm=1 tr=0 ts=63cc1c59 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=uSKb9vXQTzIYIVH47xkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0jU1vjbEp4jtNx2nptf9ekMLsf9Jg/k3GB0UuWpIduc=; b=ZeSq+MaF6sBwMIgEozsg5rwT10 f0/i67s0Wqc+x9wWGZ/M4c2gb2vA4VspGMWuT8WxvD8/ttvmS2Y6S8LeTDGn3bKdYWwGvBmuxStVm O7Cw5NpWOkwS+92JzzT+b+vbN; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:59012 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJHNA-003pI6-J8; Sat, 21 Jan 2023 10:09:44 -0700 From: Tom Tromey To: Enze Li via Gdb-patches Cc: Enze Li , enze.li@gmx.com Subject: Re: [PATCH] gdb: some int to unsigned int conversion References: X-Attribution: Tom Date: Sat, 21 Jan 2023 10:09:41 -0700 In-Reply-To: (Enze Li via Gdb-patches's message of "Sat, 21 Jan 2023 22:56:43 +0800") Message-ID: <87edrnlsq2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pJHNA-003pI6-J8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (prentzel) [97.122.76.186]:59012 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Enze" == Enze Li via Gdb-patches writes: Enze> Work around this by using unsigned int instead. Thank you, this is ok. I tend to think we should switch to bool bitfields here instead (and other spots avoiding bool), so if you want to do that, consider it pre-approved. For this sort of change we like to also change the assignments to use true/false rather than 1/0. Tom