From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 2C3573858430 for ; Tue, 10 Jan 2023 14:15:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C3573858430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 44A4410043B29 for ; Tue, 10 Jan 2023 14:14:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id FFOtpdjL2uK4dFFOtpUxgt; Tue, 10 Jan 2023 14:14:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=XpE/hXJ9 c=1 sm=1 tr=0 ts=63bd72db a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=XtfG89Hlhbwv0hT1g_AA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jIsXR2a3Mu7fosOkteI7LfAWVJryiKYddOWvITjZ6Ic=; b=w8EjMKRdBoA7iQyIeO7/nRzJ5I XIkFVZ3BEAXEN45PEiylnl48qfgzZPF+DhifLWZCzcSh8IHIyrV1BQvOhXTosYxkUkMFZz5conu8G Ruhi0Y0Jfww1DeTmR9YITBxQ7; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:40906 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFFOs-002y03-UD; Tue, 10 Jan 2023 07:14:50 -0700 From: Tom Tromey To: Jan Vrany via Gdb-patches Cc: Jan Vrany Subject: Re: [PATCH] gdb: care for dynamic objfiles in build_id_bfd_get () References: <20230109211948.604669-1-jan.vrany@labware.com> X-Attribution: Tom Date: Tue, 10 Jan 2023 07:14:47 -0700 In-Reply-To: <20230109211948.604669-1-jan.vrany@labware.com> (Jan Vrany via Gdb-patches's message of "Mon, 9 Jan 2023 21:19:48 +0000") Message-ID: <87eds28oiw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pFFOs-002y03-UD X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:40906 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Jan" == Jan Vrany via Gdb-patches writes: Jan> Accessing gdb.Objfile.build_id caused GDB to crash when objfile is Jan> dynamic, that is created by JIT reader API. Similarly, invoking Jan> gdb.Symtab.fullname() caused a crash. Possibly there are other paths Jan> that may trigger the crash. Is there a patch already for the fullname bug? Jan> + /* Dynamic objfiles such as ones created by JIT reader API Jan> + have no underlaying bfd structure (that is, objfile->obfd Jan> + is NULL). */ Jan> + if (abfd == nullptr) Jan> + return NULL; Use 'nullptr' in new code. This is ok with this change. thank you, Tom