From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 0A4BB3858421 for ; Tue, 20 Dec 2022 21:29:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A4BB3858421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id A1236100443A5 for ; Tue, 20 Dec 2022 21:04:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 7jmUpXH2Wo5OC7jmUplEgI; Tue, 20 Dec 2022 21:04:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=EZMN/NqC c=1 sm=1 tr=0 ts=63a2234a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=4m-qIzaQ7RoO-OzqkpgA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mhjvGujqX7bmq8XWxrh1Yci6PkA+BjYzK5mlW0v+MsI=; b=MdInyZrStK4ovnUGE+D9+8Bm7D pc9ViNMbWvquwSzhH4lMLEOqenq+2bs0D6fZu872eiDMuJGLldX1V7tdlBt0NjBMWLC3s4+oFv1JV Cr3iL0sj1ZuYY9O5mOikYGCeL; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:51744 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p7jmU-002P44-C2; Tue, 20 Dec 2022 14:04:10 -0700 From: Tom Tromey To: Torbjorn SVENSSON via Gdb-patches Cc: Torbjorn SVENSSON , , , Yvan Roux Subject: Re: [PATCH v2 3/4] gdb: dwarf2 generic implementation for caching function data References: <20221118155252.113476-1-torbjorn.svensson@foss.st.com> <20221118155252.113476-4-torbjorn.svensson@foss.st.com> <549c9c1f-769e-df9a-6c39-969c1eb7eb06@foss.st.com> X-Attribution: Tom Date: Tue, 20 Dec 2022 14:04:07 -0700 In-Reply-To: <549c9c1f-769e-df9a-6c39-969c1eb7eb06@foss.st.com> (Torbjorn SVENSSON via Gdb-patches's message of "Fri, 18 Nov 2022 17:01:50 +0100") Message-ID: <87edstkcs8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p7jmU-002P44-C2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:51744 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Torbjorn" == Torbjorn SVENSSON via Gdb-patches writes: >> + fn_data = FRAME_OBSTACK_ZALLOC (struct dwarf2_frame_fn_data); >> + fn_data->fn = fn; >> + fn_data->data = frame_obstack_zalloc (size); Torbjorn> Since these 2 blocks (fn_data and fn_data->fn) are allocated on the Torbjorn> obstack, do we need to release them in dwarf2_frame_dealloc_cache() or Torbjorn> just leave them to the generic garbage collection? They can just be left. The obstack as a whole is destroyed at once. However, you probably should consider the lifetime management of the data that's attached to the frame. That said, it's fine if the answer is that they should be allocated on the obstack as well. Tom