From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5A266384C90E for ; Tue, 6 Dec 2022 17:38:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A266384C90E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670348327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZKYxGshqiJiREFklyATbDQ3c1zewqPcCESLkN5Fi/kY=; b=IOwwWTYIuCypkMroQHl8QcqwOquiq+j3c0MsOGcthJvSOO6MqRcJ9qlBZQxalD5Cp62tk6 +C5YcE6UjBELHDMDCX0tC+hkl2KTcYLcP/7xG8rit37vShIhCs1VltK+ZjeKD65+dwCQYa infaiiWSr9XRnE1TujUYDoaS1I+89kw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-59-ZBPE4DSVPkyXViLXT_xbCg-1; Tue, 06 Dec 2022 12:38:45 -0500 X-MC-Unique: ZBPE4DSVPkyXViLXT_xbCg-1 Received: by mail-wr1-f70.google.com with SMTP id w11-20020adfbacb000000b002418a90da01so3434977wrg.16 for ; Tue, 06 Dec 2022 09:38:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZKYxGshqiJiREFklyATbDQ3c1zewqPcCESLkN5Fi/kY=; b=Oh9/TrEJuExKYQIDtXE7bCK97uK/vyULMfyme754cnOshst8TOaLE9qQcstUvC+N0V irQlkyAiMu51EPPq1YQF6MikdNruVmqGUuX5kbf2Cc1R39zevAq6zuP7jJO7bU+1+JRR zSNhR4NNlDWvNGe/+9up7GsMKG3CLhyCe96MP3AonuilSgwnseL+RptPMcnAs7rmoC6c rW+Sy63zVOXMlpKhVcYryPEjqZeD1Tc4iAvzuUL+W3CiUjmBMAmC0DcQVdzQW7ZFSXLF uRUQ863AaljXM5tooY0c0GE9isn0LC2ymc8dJXdd5yPXjd49ud9InjpV0IMjwfaciGU7 xnUg== X-Gm-Message-State: ANoB5pnCQIvoA56FrjcU/q1ClbrW565o8nLs2QUSHw7YsSXN2w0k1T0J pGu7tOK9INyVUct8U/joVCdXg2Hb33pJ2B3iYl56o14Gi9esZ210on6dDZUqgZ34Cg40c9wNl8h nZRJlbwpKQ8G/3Q37Kpg5vI4LwdAJZOTlsxahD3iJddaUuY301dn8rw8hBIFrKieUuZBDkr8u5g == X-Received: by 2002:a05:600c:46c8:b0:3d1:f0e3:722c with SMTP id q8-20020a05600c46c800b003d1f0e3722cmr1318135wmo.33.1670348324631; Tue, 06 Dec 2022 09:38:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ewiGZErI9XH/6rZWZ1P2rWTM2GmEE3yn99OtTPfx0J6LCcgCJq1VE3zGG1yTqBSmyGuKhkg== X-Received: by 2002:a05:600c:46c8:b0:3d1:f0e3:722c with SMTP id q8-20020a05600c46c800b003d1f0e3722cmr1318114wmo.33.1670348324356; Tue, 06 Dec 2022 09:38:44 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id f16-20020a056000129000b002421ce6a275sm17125514wrx.114.2022.12.06.09.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:38:44 -0800 (PST) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 11/12] gdb: make gdb_printing_disassembler::stream public In-Reply-To: <20221206135729.3937767-12-simon.marchi@efficios.com> References: <20221206135729.3937767-1-simon.marchi@efficios.com> <20221206135729.3937767-12-simon.marchi@efficios.com> Date: Tue, 06 Dec 2022 17:38:42 +0000 Message-ID: <87edtc300t.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > In the ROCm port, we need to access the underlying stream of a > gdb_printing_disassembler, so make it public. The reason we need to > access it is to know whether it supports style escape code. We then > pass that information to a temporary string_file we use while > symbolizing addresses. *sigh* I can't see a better way, so LGTM. Thanks, Andrew > > Change-Id: Ib95755a4a45b8f6478787993e9f904df60dd8dc1 > --- > gdb/disasm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/disasm.h b/gdb/disasm.h > index d6aec9a4705..b78374dd63f 100644 > --- a/gdb/disasm.h > +++ b/gdb/disasm.h > @@ -123,12 +123,12 @@ struct gdb_printing_disassembler : public gdb_disassemble_info > { > DISABLE_COPY_AND_ASSIGN (gdb_printing_disassembler); > > -protected: > - > /* The stream that disassembler output is being written too. */ > struct ui_file *stream () > { return m_stream; } > > +protected: > + > /* Constructor. All the arguments are just passed to the parent class. > We also add the two print functions to the arguments passed to the > parent. See gdb_disassemble_info for a description of how the > -- > 2.38.1