From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 1D92D3858D39 for ; Tue, 8 Nov 2022 17:13:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D92D3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 3E09A100459FF for ; Tue, 8 Nov 2022 17:13:21 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id sSA5okjDxhuWGsSA5o8Tjy; Tue, 08 Nov 2022 17:13:21 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Bbodbph2 c=1 sm=1 tr=0 ts=636a8e31 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=avDnBYp75V4XS2azmSkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Vnr7MoPymTPgxs6g1ekTIZTktYYDOE4u8dcTF/X8gX4=; b=gcMZtp6VCZtVWoj0evjCrjuwe7 zCYvo8GCKUYBBWSkA8cT0NdLEjkKDEJsxpWeIvtDr2R3dwuzqq1TqEjs08pH+oVm0ssn9KojcDeo+ NyNm/0zPvuPdZIpbx0/6+cc6h; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56776 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1osSA4-000gAn-NR; Tue, 08 Nov 2022 10:13:20 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 1/2] gdbsupport, gdb: add read_text_file_to_string, use it in linux_common_core_of_thread References: <20221104155137.1463129-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 08 Nov 2022 10:13:17 -0700 In-Reply-To: <20221104155137.1463129-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Fri, 4 Nov 2022 11:51:36 -0400") Message-ID: <87edud5pzm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1osSA4-000gAn-NR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56776 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> I would like to add more code to nat/linux-osdata.c that reads an entire Simon> file from /proc or /sys and processes it as a string afterwards. I Simon> would like to avoid duplicating the somewhat error-prone code that reads Simon> an entire file to a buffer. I think we should have a utility function Simon> that does that. Makes sense. source_cache::get_plain_source_lines could use this btw, though it would need some change for error reporting. Simon> + Simon> +gdb::optional Simon> +read_text_file_to_string (const char *path) Should have a comment. Simon> +extern gdb::optional read_text_file_to_string (const char *path); Here too. Tom