From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 954AA384D14D for ; Thu, 20 Oct 2022 18:44:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 954AA384D14D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id E09DC1004854B for ; Thu, 20 Oct 2022 18:44:41 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id laX3ozRoNFZ44laX3oT03b; Thu, 20 Oct 2022 18:44:41 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Z+MpoFdA c=1 sm=1 tr=0 ts=63519719 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=u1BZjErhFyNky23BUcEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eypgNjhd4jOXCnp7ylS7mpck7hs66dir+mS2lAhvEv0=; b=mKB06WmScLl/bAlvmO6ehOGMj6 tC4kJlhB6PVac5KPcAphBcFCYTY5xKfczDf6S/GdxzHU5PZ9JAaBsUCygqg5BLpqNt37/zf2N8Oql b9H4lZObUi+RT7o7n1vOq0F9Q; Received: from 71-211-181-169.hlrn.qwest.net ([71.211.181.169]:56712 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1olaX2-001P20-Io; Thu, 20 Oct 2022 12:44:40 -0600 From: Tom Tromey To: Rustam Kovhaev via Gdb-patches Cc: Rustam Kovhaev Subject: Re: [RFC PATCH] gdb: add command to clear value history References: <20221019033925.86910-1-rkovhaev@gmail.com> X-Attribution: Tom Date: Thu, 20 Oct 2022 12:44:38 -0600 In-Reply-To: <20221019033925.86910-1-rkovhaev@gmail.com> (Rustam Kovhaev via Gdb-patches's message of "Tue, 18 Oct 2022 20:39:28 -0700") Message-ID: <87edv2e3mx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.181.169 X-Source-L: No X-Exim-ID: 1olaX2-001P20-Io X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-181-169.hlrn.qwest.net (murgatroyd) [71.211.181.169]:56712 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 18:44:57 -0000 >>>>> "Rustam" == Rustam Kovhaev via Gdb-patches writes: Rustam> While debugging an application I wanted to clear the value history and I Rustam> could not find an option to do it. Rustam> I might be the only one who gets lost in the value history and I am not Rustam> sure if anyone else needs it, but I thought it would be nice to have it. Rustam> And I hope this does not break anything. Rustam> Please let me know what you think. Thanks! Thanks for the patch. In addition to what Bruno said, a new feature should have a documentation patch and also a note in NEWS. Rustam> +static void Rustam> +clear_values (const char *ignore, int from_tty) Rustam> +{ Rustam> + value_history.clear (); This is indented too much. Tom