public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 2/2] gdb/python: improve formatting of help text for user defined commands
Date: Thu, 26 May 2022 11:46:21 -0600	[thread overview]
Message-ID: <87ee0g6vbm.fsf@tromey.com> (raw)
In-Reply-To: <874k1njg8b.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 18 May 2022 11:19:00 +0100")

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> Thanks to Eli and Lancelot for their feedback.

Andrew> In this revision I have:
Andrew>   - Updated the NEWS entry in line with Eli's feedback,
Andrew>   - Updated some comments that Lancelot identified as being out of date,
Andrew>   - Added an additional comment into the test script to justify some
Andrew>     'verbose -log' lines.
Andrew>   - There's no functional change to the code.

This looks ok to me, thank you.

Tom

  parent reply	other threads:[~2022-05-26 17:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 10:51 [PATCH 0/2] Improve help test for commands defined in Python Andrew Burgess
2022-05-17 10:51 ` [PATCH 1/2] gdb: use gdb::unique_xmalloc_ptr<char> for docs in cmdpy_init Andrew Burgess
2022-05-26 17:43   ` Tom Tromey
2022-05-28 10:10     ` Andrew Burgess
2022-05-17 10:51 ` [PATCH 2/2] gdb/python: improve formatting of help text for user defined commands Andrew Burgess
2022-05-17 12:19   ` Eli Zaretskii
2022-05-17 22:41   ` Lancelot SIX
2022-05-18 10:19   ` Andrew Burgess
2022-05-18 12:09     ` Eli Zaretskii
2022-05-26 17:46     ` Tom Tromey [this message]
2022-05-28 10:11       ` Andrew Burgess
2022-05-31 21:54         ` Carl Love
2022-05-31 23:10           ` Carl Love
2022-06-03 18:05             ` Carl Love
2022-06-06 11:40               ` [PUSHED] gdb/testsuite: add missing skip_python_tests call in py-doc-reformat.exp Andrew Burgess
2022-06-07 16:08                 ` Carl Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee0g6vbm.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).