From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 484063858D37 for ; Fri, 22 Apr 2022 17:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 484063858D37 Received: by mail-il1-x129.google.com with SMTP id y16so5511128ilc.7 for ; Fri, 22 Apr 2022 10:55:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=imyEVMPOiStv6KeFFdsp8FcX4SZ2jrgBgPXGUh1ml6o=; b=M9L8x/o93o6iUlniZ96UzNhlpIjEm2g2kwvNsxqfWkxqIgsc9aWfy5wMdRC1zxxmwS km1OHQMZYS/IyViTS9COyQtnRMwrr99vpstALe3zaQuVyg7uX1E0Lhk+RB2WLFNtZ12c s1ydRiYEQR7SUhw9BHUKgnXMBWS5iQ0q5uTfWQNKY7Hpvgo+/OAVCevPbAIDmHIIbnAv 8iaYUc8p4H5i4Tel5BcQzFhMCW1iFqxb/gdE6qyQw30hOPSKjWsPXK5luSm+/tPFPchM EesbeY1vnZS8cdkG5YmcrQe5XFS8h9p1xjcJ2+8YfHUgxJszjp9rLWwRk+eyQiJNWVCJ sJng== X-Gm-Message-State: AOAM532lE4+yO3YwxT6l+a3c8H6fUk+HNwOp5EGkaoU1OcYSbxom03DL WGSQt2RYdGGm7gReQE2U7SXXH1o1DdmZNA== X-Google-Smtp-Source: ABdhPJwDZm30aLYPcEJZAjERP+c1uOcrtsNsa5i7J76TatPLNlrXQOvLDESev8NDSNku3Y4+EXbrwA== X-Received: by 2002:a92:3405:0:b0:2c8:70ad:fa86 with SMTP id b5-20020a923405000000b002c870adfa86mr2507841ila.268.1650650130411; Fri, 22 Apr 2022 10:55:30 -0700 (PDT) Received: from murgatroyd (71-211-158-194.hlrn.qwest.net. [71.211.158.194]) by smtp.gmail.com with ESMTPSA id x9-20020a6bda09000000b006545a38b1acsm1863463iob.47.2022.04.22.10.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:55:29 -0700 (PDT) From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Do not double-read minimal symbols for PE COFF References: <20220422174014.2645411-1-tromey@adacore.com> <83ilr1ovwn.fsf@gnu.org> X-Attribution: Tom Date: Fri, 22 Apr 2022 11:55:28 -0600 In-Reply-To: <83ilr1ovwn.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Apr 2022 20:44:24 +0300") Message-ID: <87ee1pq9yn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 17:55:32 -0000 >>>>> "Eli" == Eli Zaretskii writes: >> Date: Fri, 22 Apr 2022 11:40:14 -0600 >> From: Tom Tromey via Gdb-patches >> Cc: Tom Tromey >> >> This changes coffread.c to avoid re-reading minimal symbols when >> possible. This only works when there are no COFF symbols to be read, >> but at least for my mingw builds of gdb, this seems to be the case. Eli> coffread.c is also used bu go32 (a.k.a. DJGPP) build of GDB. What Eli> does this change mean for programs compiled with COFF debug info? It shouldn't change anything. It's just an optimization. Tom