From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F24573858D37 for ; Sun, 3 Apr 2022 16:17:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F24573858D37 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-9SgEpcppNA2dO6FcK1TC8g-1; Sun, 03 Apr 2022 12:17:28 -0400 X-MC-Unique: 9SgEpcppNA2dO6FcK1TC8g-1 Received: by mail-wm1-f70.google.com with SMTP id n19-20020a7bcbd3000000b0038c94b86258so3815090wmi.2 for ; Sun, 03 Apr 2022 09:17:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=YEAvQ2ta19mnUq1KIUpW9SJos7LCaEeWnGiRWXz+xXI=; b=OZSModKoR3eyTGNOmvXmj8qewF0e89lDmR7yJ8zmLWxX30NmS2YS04aBbA0TsCmvKY qJDIgpM8wSEYi2Abf7gFTfsqS7SLy6AZ7wUfwiXlDr4ntDAnsyIggYKWewd5nq6xU7vp /e5cd1ZP9Z1g7rcxE5kguFutlovR/e4lR/ls4TyYyWyr9wKJgJWqb0rqcLi+eYS1friK zzH+x0RSsza+z6FPEDz4ReDpPCSgF/tIrUJxzc64Wt3bdlGy8NhiKC881801igPNKKAg gW3jp11jkQufDATFZyrKRU41yu738U3tH7gELKvQyHit346zQlA04K0rMaKPdRs4l7JL ZcRg== X-Gm-Message-State: AOAM530qU6rRQfmfqheJhr112wPg5yh1llk6hiC8nz2Rk6UBL4syF7Jo 5yT638RjWnIK9Z4FuHZYDTdciejNbQUpzaBpjt76mC9dwbzDGVQXWLdVCCnQ8hT5C5SZkW0xsIh L0ueTIxrUzOBGV7A6xJlGqw== X-Received: by 2002:adf:eb4d:0:b0:1ed:c1f7:a951 with SMTP id u13-20020adfeb4d000000b001edc1f7a951mr13899207wrn.454.1649002647099; Sun, 03 Apr 2022 09:17:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWmYaQcTGeTlFnBvK9/32hBrwbl659Nz66x2N5r3jcxUklxtnECUfc7SUuph7C5hhMSXvr2g== X-Received: by 2002:adf:eb4d:0:b0:1ed:c1f7:a951 with SMTP id u13-20020adfeb4d000000b001edc1f7a951mr13899200wrn.454.1649002646939; Sun, 03 Apr 2022 09:17:26 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id j17-20020a05600c1c1100b0038e389ab62esm18341439wms.9.2022.04.03.09.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 09:17:26 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Allow non-ASCII characters in Rust identifiers In-Reply-To: <87y22nwxqb.fsf@tromey.com> References: <20220126231501.1031201-1-tom@tromey.com> <87y22nwxqb.fsf@tromey.com> Date: Sun, 03 Apr 2022 17:17:25 +0100 Message-ID: <87ee2e87l6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2022 16:17:31 -0000 Tom Tromey writes: >>>>>> "Tom" =3D=3D Tom Tromey writes: > > Tom> Rust 1.53 (quite a while ago now) ungated the support for non-ASCII > Tom> identifiers. This didn't work in gdb. This is PR rust/20166. > > I'm checking this in. Hi Tom! I'm seeing this test fail. $ rustc --version rustc 1.59.0 (9d1b2106e 2022-02-23) I've tested with gdb commit a723766c0e2 and 5187219460c. Here's the output from gdb.log: (gdb) run=20 Starting program: /home/andrew/projects/binutils-gdb/build/gdb/testsuite/= outputs/gdb.rust/unicode/unicode=20 [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". =20 Breakpoint 1, unicode::main () at /home/andrew/projects/binutils-gdb/buil= d/gdb/testsuite/../../../src/gdb/testsuite/gdb.rust/unicode.rs:25 25 println!("{}, {}", =C3=B0=C2=AF, c=C3=A7); = // set breakpoint here (gdb) print =C3=B0=C2=AF unexpected token (gdb) FAIL: gdb.rust/unicode.exp: print D print "=C3=B0=C2=AF" $1 =3D "=C3=B0\302\235\302\225=C2=AF" (gdb) FAIL: gdb.rust/unicode.exp: print D in string print '=C3=B0=C2=AF' Unterminated character literal (gdb) FAIL: gdb.rust/unicode.exp: print D as char print c=C3=A7 No symbol 'c' in current context (gdb) FAIL: gdb.rust/unicode.exp: print cc print '=C3=A7c' Unterminated character literal (gdb) FAIL: gdb.rust/unicode.exp: print cc as char Do these pass for you? Any suggestions for where to start looking? Thanks, Andrew