From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id CD0513858D34 for ; Sat, 18 Sep 2021 01:16:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD0513858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by gproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id 48D898032DBA for ; Sat, 18 Sep 2021 01:16:00 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ROxTmDkjeEV4rROxUmWZy2; Sat, 18 Sep 2021 01:16:00 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NJkQR22g c=1 sm=1 tr=0 ts=61453dd0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=7QKq2e-ADPsA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=n581oiHJjL_EgP30T0kA:9 a=QYH75iMubAgA:10:nop_sms_unsolicited DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=i6DQvluIcnekwdgtFT5D4uoKueZH5YfSz/ANHkloE3s=; b=vrhycJfotWmM6CEuDprkA97fsb zK9kbKSNFFBJldGM/XxamOcb0sw8hGND3DUkyk9smXVWwGGNyAa658n6Ff2176j/t4R+aBDymVd+Y FpZYBnP93sQG5KZZKJg5YF9YG; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:57458 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mROxT-000y9Z-K8; Fri, 17 Sep 2021 19:15:59 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Tom de Vries via Gdb-patches Subject: Re: [PATCH][gdb/ada] Handle artificial local symbols References: <20210824111357.GA28507@delia> <87zgsbng4x.fsf@tromey.com> <91f01f82-446e-9e80-692f-11cfefb7c4ee@suse.de> X-Attribution: Tom Date: Fri, 17 Sep 2021 19:15:58 -0600 In-Reply-To: <91f01f82-446e-9e80-692f-11cfefb7c4ee@suse.de> (Tom de Vries's message of "Sat, 18 Sep 2021 01:28:01 +0200") Message-ID: <87ee9mof8x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mROxT-000y9Z-K8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (localhost.localdomain) [174.16.0.219]:57458 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Sep 2021 01:16:02 -0000 >> I think making this bool would be better. Tom> Hmm, the struct is advertised as space-critical, and a 1-bit bitfield is Tom> smaller than an 8-bit bool. So I wonder why you prefer bool here. Sorry, I meant 'bool ... : 1', which should work ok. Tom