Re: [gdb/build] Fix Werror=nonnull-compare build breaker with gcc 12

[Tom Tromey <tom@tromey.com>]

Tom> I managed now to reproduce, and wrote a patch along these lines.

Tom> Any comments?

Tom> In particular, any suggestion where to put ignore_nonnull?

Tom> Or, is it perhaps a better idea to have a gdb_assert_nonnull and
Tom> implement things there?

How about we either drop the nonnull attribute or we use
-fno-delete-null-pointer-checks?

I personally feel that the gcc approach in this area is
counter-productive, at least for our purposes.  My view is that the
point of this stuff is to help us detect programming errors -- and we're
uninterested in using non-null-ness as some kind of optimization hint.
gcc seems to want it both ways, which seems bizarre.  But, given that
this is how the compiler works, IMO we should choose reliability
whichever way we best can.

thanks,
Tom