From: Tom Tromey <tom@tromey.com>
To: Sourabh Singh Tomar via Gdb-patches <gdb-patches@sourceware.org>
Cc: Sourabh Singh Tomar <SourabhSingh.Tomar@amd.com>
Subject: Re: [PATCH] Fix macro info lookup for binaries containing DWARFv5 line table
Date: Thu, 13 May 2021 09:47:57 -0600 [thread overview]
Message-ID: <87eeea63f6.fsf@tromey.com> (raw)
In-Reply-To: <20210512171655.9463-1-SourabhSingh.Tomar@amd.com> (Sourabh Singh Tomar via Gdb-patches's message of "Wed, 12 May 2021 22:46:55 +0530")
>>>>> ">" == Sourabh Singh Tomar via Gdb-patches <gdb-patches@sourceware.org> writes:
>> +standard_testfile
>> +set additional_flags {debug}
>> +file copy -force $srcdir/$subdir/$srcfile [standard_output_file $srcfile]
>> +gdb_compile outputs/gdb.base/dwarf5-macro/dwarf5-macro.c $binfile executable {debug}
If the copying is really needed, then a comment explaining why would be
helpful.
I'm not sure if "file copy" can be used. You may want to see what other
tests do, I think maybe dejagnu provides some wrapper. Not really sure.
This set 'additional_flags' but doesn't use it. You could just drop the
assignment.
>> +if { [test_compiler_info "gcc-*"] } {
>> + set options "additional_flags=-g3"
>> +} elseif { [test_compiler_info "clang-*"] } {
>> + set options "additional_flags=-gdwarf-5 -fdebug-macro"
It seems like you'd want to pass -gdwarf-5 to gcc as well?
>> +if { [prepare_for_testing "failed to prepare" \
>> + ${testfile} ${srcfile}] } {
No need to break this line, I think.
>> +set filepat {dwarf5-macro.[ch]}
>> +set definition {}
>> +set location {}
>> +set nonzero {[1-9][0-9]*}
None of these are used.
Tom
next prev parent reply other threads:[~2021-05-13 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 17:16 Sourabh Singh Tomar
2021-05-12 17:31 ` Tomar, Sourabh Singh
2021-05-13 15:47 ` Tom Tromey [this message]
2021-05-13 18:20 ` Simon Marchi
2021-05-14 14:56 ` Keith Seitz
2021-05-14 18:21 ` Tomar, Sourabh Singh
2021-05-14 18:50 ` Simon Marchi
2021-05-14 19:20 ` Tomar, Sourabh Singh
2021-05-14 20:56 ` Simon Marchi
2021-05-24 11:36 ` Tomar, Sourabh Singh
2021-05-24 18:47 ` Keith Seitz
2021-06-08 18:48 ` Keith Seitz
2021-06-22 17:01 ` [RFC] PING [Re: [PATCH] Fix macro info lookup for binaries containing DWARFv5 line table] Keith Seitz
2021-06-22 20:52 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeea63f6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=SourabhSingh.Tomar@amd.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).