From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.119]) by sourceware.org (Postfix) with ESMTPS id DC04F3854821 for ; Thu, 13 May 2021 15:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC04F3854821 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 5AEEB116BB for ; Thu, 13 May 2021 10:47:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id hDZ8lwMjpnrr4hDZ8lvydm; Thu, 13 May 2021 10:47:58 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=M9oFKv6XOR4UksrVxSDNhgww36F1zydA2kqYd4ugpgA=; b=fVKbucPBUWGdhpwVkqf/MoA1cy FsRWbaHR1+X+J8ZnOi11PN2xI6L9Qvaes6uPMiqIwxfOBrFWQVijQQNMmPMYZR8lUtltU/jYFMQ4j mEamfDUYRHLf+VTfSYSWl2RxC; Received: from 75-166-134-27.hlrn.qwest.net ([75.166.134.27]:52780 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lhDZ7-001tLg-Rr; Thu, 13 May 2021 09:47:57 -0600 From: Tom Tromey To: Sourabh Singh Tomar via Gdb-patches Cc: Sourabh Singh Tomar Subject: Re: [PATCH] Fix macro info lookup for binaries containing DWARFv5 line table References: <20210512171655.9463-1-SourabhSingh.Tomar@amd.com> X-Attribution: Tom Date: Thu, 13 May 2021 09:47:57 -0600 In-Reply-To: <20210512171655.9463-1-SourabhSingh.Tomar@amd.com> (Sourabh Singh Tomar via Gdb-patches's message of "Wed, 12 May 2021 22:46:55 +0530") Message-ID: <87eeea63f6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.27 X-Source-L: No X-Exim-ID: 1lhDZ7-001tLg-Rr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-27.hlrn.qwest.net (murgatroyd) [75.166.134.27]:52780 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2021 15:48:03 -0000 >>>>> ">" == Sourabh Singh Tomar via Gdb-patches writes: >> +standard_testfile >> +set additional_flags {debug} >> +file copy -force $srcdir/$subdir/$srcfile [standard_output_file $srcfile] >> +gdb_compile outputs/gdb.base/dwarf5-macro/dwarf5-macro.c $binfile executable {debug} If the copying is really needed, then a comment explaining why would be helpful. I'm not sure if "file copy" can be used. You may want to see what other tests do, I think maybe dejagnu provides some wrapper. Not really sure. This set 'additional_flags' but doesn't use it. You could just drop the assignment. >> +if { [test_compiler_info "gcc-*"] } { >> + set options "additional_flags=-g3" >> +} elseif { [test_compiler_info "clang-*"] } { >> + set options "additional_flags=-gdwarf-5 -fdebug-macro" It seems like you'd want to pass -gdwarf-5 to gcc as well? >> +if { [prepare_for_testing "failed to prepare" \ >> + ${testfile} ${srcfile}] } { No need to break this line, I think. >> +set filepat {dwarf5-macro.[ch]} >> +set definition {} >> +set location {} >> +set nonzero {[1-9][0-9]*} None of these are used. Tom