From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.100]) by sourceware.org (Postfix) with ESMTPS id 37F283858012 for ; Thu, 1 Apr 2021 17:44:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 37F283858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway32.websitewelcome.com (Postfix) with ESMTP id C24C3632ABE for ; Thu, 1 Apr 2021 12:44:27 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id S1Mpl2NRcMGeES1Mpldk75; Thu, 01 Apr 2021 12:44:27 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jMtlYqzDnCdNzikZjJSs29ltCCM0vlNNIldf7BCJ+HY=; b=gFwg7rpv4QCHJekJNmR8+pOqep +vDKSEndpgtgWsP/IBK5Yr8I5dK4uSPf5eb519w+SgWwe8QMWWIuqM8iA0GyV0IIDmH+b7QM79Fg3 coCVt9YJizA9mjFaFhodl5xsY; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:44522 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lS1Mp-0017gK-78; Thu, 01 Apr 2021 11:44:27 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Christian Biesinger , Simon Marchi , Simon Marchi Subject: Re: [PATCH 1/4] gdb: add intern method to objfile_per_bfd_storage References: <20210322193417.2376788-1-simon.marchi@efficios.com> <20210322193417.2376788-2-simon.marchi@efficios.com> <13c62035-c0e2-06cf-aeb7-4ae515b90c27@polymtl.ca> X-Attribution: Tom Date: Thu, 01 Apr 2021 11:44:26 -0600 In-Reply-To: <13c62035-c0e2-06cf-aeb7-4ae515b90c27@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 23 Mar 2021 11:48:49 -0400") Message-ID: <87eeftq4qt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lS1Mp-0017gK-78 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:44522 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 17:44:29 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> In this particular case, callers of this intern method have a C string Simon> and an std::string, so we know they are null-terminated. It seems a little dangerous to do this, though, in that someone might add a call without remembering or checking the invariant. Maybe it's better to just have 2 overloads on the per-bfd object. Tom