From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: update command completion for watch, awatch, and rwatch
Date: Wed, 18 Nov 2020 09:55:10 -0700 [thread overview]
Message-ID: <87eekqk3kh.fsf@tromey.com> (raw)
In-Reply-To: <b7510f203c629af66b66147a25f62b11ec5087b0.1605565082.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Mon, 16 Nov 2020 22:19:06 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> The interactive help text for these commands now emphasises
Andrew> '-location' as the real option, but does mention that '-l' can also be
Andrew> used.
Andrew> gdb/ChangeLog:
Andrew> * breakpoint.c (struct watch_options): New struct.
Andrew> (watch_option_defs): New static global.
Andrew> (make_watch_options_def_group): New function.
Andrew> (watch_maybe_just_location): Convert option parsing.
Andrew> (watch_command_completer): New function.
Andrew> (_initialize_breakpoint): Build help text using options mechanism.
Thank you for doing this. This looks good to me.
Andrew> +Usage: watch [-location] EXPRESSION\n\
Not relevant for this patch, but I've wondered if these Usage lines
should explain the full syntax, like '[if EXPRESSION]' and '[thread ID]'
Tom
prev parent reply other threads:[~2020-11-18 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 22:19 [PATCH 0/2] Improving tab completion for watch commands Andrew Burgess
2020-11-16 22:19 ` [PATCH 1/2] gdb: convert some function arguments from int to bool Andrew Burgess
2020-11-18 16:15 ` Tom Tromey
2020-11-16 22:19 ` [PATCH 2/2] gdb: update command completion for watch, awatch, and rwatch Andrew Burgess
2020-11-18 16:55 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eekqk3kh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).