From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.197.22]) by sourceware.org (Postfix) with ESMTPS id 26B683893677 for ; Fri, 24 Apr 2020 19:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 26B683893677 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id B6DE24013EF07 for ; Fri, 24 Apr 2020 14:09:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id S4MdjKcoZSl8qS4MdjkqQx; Fri, 24 Apr 2020 14:51:55 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OaygDK6p7xCiQEC7lWJedbJFQppe2d6jg3ij0GX3sl8=; b=MCGSKOhMz5KBAd+pq5rve/uUMe dmoxjqb4YBmUt7pqIIBjxGwm7yDUVp+JSpvNPFGjb6YQ2nJ/qe1sRvR5KAsJTZoIdPsQs+qzbckq5 Ee/S5ypt6b9TpfdP8XJHgxx8k; Received: from 184-96-229-138.hlrn.qwest.net ([184.96.229.138]:52562 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jS4Md-001NmF-BW; Fri, 24 Apr 2020 13:51:55 -0600 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Add completion styling References: <20200409024112.18065-1-tom@tromey.com> <83369dp3gy.fsf@gnu.org> X-Attribution: Tom Date: Fri, 24 Apr 2020 13:51:54 -0600 In-Reply-To: <83369dp3gy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Apr 2020 09:39:41 +0300") Message-ID: <87eesc1x2d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.229.138 X-Source-L: No X-Exim-ID: 1jS4Md-001NmF-BW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-229-138.hlrn.qwest.net (murgatroyd) [184.96.229.138]:52562 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 19:51:57 -0000 >>>>> "Eli" == Eli Zaretskii writes: Thanks for your comments. >> Readline has a styling feature for completion -- if it is enabled, the >> common prefix of completions will be displayed in a different style. >> This doesn't work in gdb, because gdb implements its own completer. >> >> This patch implements the feature. However, it doesn't directly use >> the Readline feature, because gdb can do a bit better: it can let the >> user control the styling using the existing mechanisms. Eli> Would it make sense to default to the style determined by the user's Eli> colored-completion-prefix setting? That's a bit of a pain because readline parses LS_COLORS on its own. This doesn't seem to be documented anywhere. I'm reluctant to try to use readline's code, because it is using "_" prefixes; in readline these indicate private items and there's at least one bug report about this in bugzilla already (some distro made these hidden in the .so and it broke gdb). Eli> Also, do we want the default styling to be no-styling, or do we want Eli> something else? I would prefer to enable it by default. It's easy to disable if one prefers. Eli> Btw, Emacs solves this problem differently: it uses a distinct styling Eli> for the first character that distinguishes between completion Eli> candidates. I wonder if that idea is more useful for quickly Eli> realizing what one needs to type next. Or do we want to follow Eli> Readline here for consistency reasons? I think the Emacs idea is nice. Maybe we want to let the user control the prefix text, the "difference character", and the final completion text. Tom