From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1314 invoked by alias); 30 Apr 2019 15:45:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1212 invoked by uid 89); 30 Apr 2019 15:45:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:761, H*RU:192.185.145.171, HX-Spam-Relays-External:192.185.145.171, wish X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Apr 2019 15:45:15 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 71B781B20F63 for ; Tue, 30 Apr 2019 10:45:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id LUwUhRJ51dnCeLUwUhBbDk; Tue, 30 Apr 2019 10:45:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hKzOA5la5RaE/aRJyBTmmGgM7APFgCInOnL+RG/cjAk=; b=rORY2vTjXYzuVSixmjknjTVWCM ItC5jE36JcSSdpH4jCf6TxhttHlffkgmKei4trO45yIjNBDc3L76rL4us6brkvyTT3+l0MUYfBAtL 5Qc+BtF16nwyYFphyI+cswWWF; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:43430 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hLUwU-002tYs-8Q; Tue, 30 Apr 2019 10:45:14 -0500 From: Tom Tromey To: Amos Bird Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add "thread-exited" annotation References: <87d0l8pzdz.fsf@gmail.com> Date: Tue, 30 Apr 2019 15:45:00 -0000 In-Reply-To: <87d0l8pzdz.fsf@gmail.com> (Amos Bird's message of "Fri, 26 Apr 2019 23:19:52 +0800") Message-ID: <87ef5j33au.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00655.txt.bz2 >>>>> "Amos" == Amos Bird writes: Amos> This patch adds "thread-exited" annotation so that annotation based Amos> clients like cgdb could currently handle thread exit. I sort of wish that all clients would just use MI, but ... Amos> +2019-04-26 Amos Bird Amos> + Amos> + * annotate.c (annotate_thread_exited): Add "thread-exited" Amos> + annotation. The patch itself is fine (just some nits), but a change like this requires a documentation update (and probably NEWS as well) and a test case. Amos> +void Amos> +annotate_thread_exited (struct thread_info *t, int silent) Amos> +{ New functions should have an intro comment. Also, this function should be "static". Tom