From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Tom Tromey <tom@tromey.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove a VEC from remote.c
Date: Fri, 09 Nov 2018 23:05:00 -0000 [thread overview]
Message-ID: <87efbtvol2.fsf@tromey.com> (raw)
In-Reply-To: <f76e8c80-9a3a-ae13-4f8a-3fedd48755e8@ericsson.com> (Simon Marchi's message of "Fri, 9 Nov 2018 22:13:37 +0000")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>> + data->guesses.push_back (new_guess);
Simon> I always prefer having a constructor and using
Simon> data-> guesses.emplace_back (bytes, tdesc);
Simon> since it makes it impossible to have uninitialized fields by mistake.
I'm checking it in with this change.
Tom
prev parent reply other threads:[~2018-11-09 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 16:06 Tom Tromey
2018-11-09 22:34 ` Simon Marchi
2018-11-09 23:05 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efbtvol2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).