From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121933 invoked by alias); 30 Oct 2018 20:55:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121921 invoked by uid 89); 30 Oct 2018 20:55:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:689, simon.marchi@ericsson.com, simonmarchiericssoncom, H*f:sk:e334bc9 X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 20:55:47 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id B826247D9 for ; Tue, 30 Oct 2018 15:55:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Hb3BgX1BMaSeyHb3BgowFL; Tue, 30 Oct 2018 15:55:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wfDZi5z1XcFgs6gE4kSNXjaM94RFXHuZsjQm/7cEXmk=; b=xSX2Xz6ZOw4RBS+nJOktlJmDFt nqaVUoDt1rkCMx4RpflNahj+0NTEV3KIktzhAAnUIvDyCLOiV0s5hXviSB3ZXwEQ/ZLLHTGLMQOIW /fNjATw21KyS7JsWJz6Hbp238; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:57896 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gHb3B-0047zN-F4; Tue, 30 Oct 2018 15:55:45 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c References: <20181018223100.20693-1-tom@tromey.com> <20181018223100.20693-4-tom@tromey.com> <6a239617-b748-0a9f-185b-2adcb19c50bc@ericsson.com> Date: Tue, 30 Oct 2018 20:55:00 -0000 In-Reply-To: <6a239617-b748-0a9f-185b-2adcb19c50bc@ericsson.com> (Simon Marchi's message of "Mon, 29 Oct 2018 22:16:00 +0000") Message-ID: <87efc7nohb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00724.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> What do you think about this? Thanks for doing this. Simon> /* See common/pathstuff.h. */ Simon> +std::string Simon> +get_standard_temp_dir () Simon> +{ Simon> +#ifdef WIN32 Simon> + char *tmp = getenv ("TMP"); Simon> + if (tmp != nullptr) Simon> + return tmp; Simon> + Simon> + tmp = getenv ("TEMP"); Simon> + if (tmp != nullptr) Simon> + return tmp; Simon> + Simon> + error (_("Couldn't find temp dir path, both TMP and TEMP are unset.")); Simon> + Simon> +#else Simon> + return "/tmp"; It would be normal to look at TMPDIR on unix systems. Tom