From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96868 invoked by alias); 24 Apr 2018 23:11:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96858 invoked by uid 89); 24 Apr 2018 23:11:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.199.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 23:11:32 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 33873400CFA0A for ; Tue, 24 Apr 2018 18:11:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id B75vfKChQ5CKDB75vfsDeS; Tue, 24 Apr 2018 18:11:31 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:36262 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fB75u-003V7P-T6; Tue, 24 Apr 2018 18:11:30 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/8] Use counted_command_line everywhere References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-3-tom@tromey.com> Date: Tue, 24 Apr 2018 23:11:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 24 Apr 2018 17:43:04 +0100") Message-ID: <87efj48aji.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fB75u-003V7P-T6 X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:36262 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00493.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> - for (i = 0; i < action->body_count; ++i) >> - trace_dump_actions (action->body_list[i], >> - 1, stepping_frame, from_tty); >> + trace_dump_actions (action->body_list_0.get (), >> + 1, stepping_frame, from_tty); >> + trace_dump_actions (action->body_list_1.get (), >> + 1, stepping_frame, from_tty); Pedro> Hmm, this looked suspicious. I'm not seeing why would a Pedro> while-stepping action have two body lists. I guess this Pedro> happens to work because trace_dump_actions does nothing Pedro> if ACTION is NULL. Yeah. If you prefer I can add an assert that body_list_1==nullptr, which seems like it ought to always be true. >> + gdb::unique_xmalloc_ptr default_collect_line >> + (xstrprintf ("collect %s", default_collect)); Pedro> string_printf ? I'll do that. Pedro> It's a shame that we can't use std::make_shared to avoid Pedro> the separate control block allocation. It could be done if we changed the representation a bit, but it looked like a pain to me, so I didn't. Tom