From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76056 invoked by alias); 1 Sep 2016 18:58:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76046 invoked by uid 89); 1 Sep 2016 18:58:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Wait, _not_ X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Sep 2016 18:58:00 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8CE2C8123C for ; Thu, 1 Sep 2016 18:57:59 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u81IvwZv030764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 1 Sep 2016 14:57:59 -0400 From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH 2/2] Share target_wait prototype between GDB and gdbserver References: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> <1472443911-29056-3-git-send-email-sergiodj@redhat.com> <49223e65-a30b-7e0e-d545-35799d73b6f7@redhat.com> X-URL: http://blog.sergiodj.net Date: Thu, 01 Sep 2016 18:58:00 -0000 In-Reply-To: <49223e65-a30b-7e0e-d545-35799d73b6f7@redhat.com> (Pedro Alves's message of "Wed, 31 Aug 2016 11:29:43 +0100") Message-ID: <87eg5330sp.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00027.txt.bz2 On Wednesday, August 31 2016, Pedro Alves wrote: > On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote: > >> --- a/gdb/target.h >> +++ b/gdb/target.h >> @@ -1341,18 +1341,6 @@ extern void target_disconnect (const char *, int); >> >> extern void target_resume (ptid_t ptid, int step, enum gdb_signal signal); >> >> -/* Wait for process pid to do something. PTID = -1 to wait for any >> - pid to do something. Return pid of child, or -1 in case of error; >> - store status through argument pointer STATUS. Note that it is >> - _NOT_ OK to throw_exception() out of target_wait() without popping >> - the debugging target from the stack; GDB isn't prepared to get back >> - to the prompt with a debugging target but without the frame cache, >> - stop_pc, etc., set up. OPTIONS is a bitwise OR of TARGET_W* >> - options. */ >> - >> -extern ptid_t target_wait (ptid_t ptid, struct target_waitstatus *status, >> - int options); >> - > > Please leave a breadcrumb comment here, like was done for > target_read_memory, for example: > > /* For target_read_memory see target/target.h. */ Fixed and pushed: f2b9e3dfd4bc3c5149496fdbeaa5f0907220685f Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/