From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24583 invoked by alias); 10 Oct 2014 16:38:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24559 invoked by uid 89); 10 Oct 2014 16:38:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 10 Oct 2014 16:38:35 +0000 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9AGcWLQ012209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Oct 2014 16:38:32 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9AGcVt4015997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 10 Oct 2014 16:38:32 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9AGcVGx015971; Fri, 10 Oct 2014 16:38:31 GMT Received: from termi.oracle.com (/10.175.211.52) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 10 Oct 2014 09:38:30 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/9] Adapt `info probes' to support printing probes of different types. References: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> <1411724905-31234-2-git-send-email-jose.marchesi@oracle.com> <87d2ae9lh2.fsf@redhat.com> Date: Fri, 10 Oct 2014 16:38:00 -0000 In-Reply-To: <87d2ae9lh2.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 29 Sep 2014 17:15:53 -0400") Message-ID: <87egufevaz.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00253.txt.bz2 Hi Sergio. > A "probe type" (backend for the probe abstraction implemented in probe.[ch]) > can extend the information printed by `info probes' by defining additional > columns. This means that when `info probes' is used to print all the probes > regardless of their types, some of the columns will be "not applicable" to > some of the probes (like, say, the Semaphore column only makes sense for > SystemTap probes). This patch makes `info probes' fill these slots with "n/a" > marks (currently it breaks the table) and not include headers for which no > actual probe has been found in the list of defined probes. Thanks for the patch, Jose. Comments below. I agree/comply with all these comments :)