From: Tom Tromey <tromey@redhat.com>
To: Sanimir Agovic <sanimir.agovic@intel.com>
Cc: palves@redhat.com, xdje42@gmail.com, gdb-patches@sourceware.org,
keven.boell@intel.com
Subject: Re: [PATCH v4 02/13] type: add c99 variable length array support
Date: Wed, 15 Jan 2014 21:07:00 -0000 [thread overview]
Message-ID: <87eh49osy8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1387282678-3847-3-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Tue, 17 Dec 2013 13:17:47 +0100")
>>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
Sanimir> +int
Sanimir> +dwarf2_evaluate_property (const struct dynamic_prop *prop, CORE_ADDR address,
Sanimir> + CORE_ADDR *value)
Sanimir> +{
[...]
Sanimir> + if (!value_optimized_out (val))
Sanimir> + *value = value_as_long (value_ind (val));
Sanimir> + }
Sanimir> + return 1;
This particular branch can return 1 but not set *value.
That seems wrong.
Sanimir> + else if (attr_form_is_block (target_attr))
Sanimir> + {
Sanimir> + const gdb_byte ops[] = {DW_OP_deref};
Sanimir> +
Sanimir> + baton = obstack_alloc (obstack, sizeof (*baton));
Sanimir> + baton->locexpr = block_to_locexpr_baton (DW_BLOCK (target_attr),
Sanimir> + cu, ops, sizeof (ops));
I noted in an earlier review that I think this approach will not work.
Not sure if I'm misunderstanding something; but I dug up the old thread
and you didn't respond to this bit:
https://sourceware.org/ml/gdb-patches/2013-11/msg00785.html
The rest of this seemed fine to me.
Tom
next prev parent reply other threads:[~2014-01-15 21:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 12:18 [PATCH v4 00/13] C99 " Sanimir Agovic
2013-12-17 12:18 ` [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2013-12-18 3:24 ` Joel Brobecker
2013-12-18 15:59 ` Agovic, Sanimir
2014-01-15 21:39 ` Tom Tromey
2014-01-16 2:45 ` Joel Brobecker
2014-01-16 17:03 ` Agovic, Sanimir
2014-01-16 17:39 ` Tom Tromey
2013-12-17 12:18 ` [PATCH v4 06/13] vla: print "variable length" for unresolved dynamic bounds Sanimir Agovic
2013-12-17 12:18 ` [PATCH v4 04/13] vla: enable sizeof operator for indirection Sanimir Agovic
2014-01-15 21:28 ` Tom Tromey
2014-01-16 17:02 ` Agovic, Sanimir
2013-12-17 12:18 ` [PATCH v4 02/13] type: add c99 variable length array support Sanimir Agovic
2014-01-15 21:07 ` Tom Tromey [this message]
2014-01-16 17:01 ` Agovic, Sanimir
2013-12-17 12:18 ` [PATCH v4 07/13] vla: support for DW_AT_count Sanimir Agovic
2013-12-17 12:18 ` [PATCH v4 05/13] vla: update type from newly created value Sanimir Agovic
2013-12-18 3:44 ` Joel Brobecker
2013-12-17 12:19 ` [PATCH v4 03/13] vla: enable sizeof operator to work with variable length arrays Sanimir Agovic
2014-01-15 21:24 ` Tom Tromey
2013-12-17 12:19 ` [PATCH v4 10/13] test: multi-dimensional c99 vla Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 11/13] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 12/13] test: basic c99 vla tests for C primitives Sanimir Agovic
2014-01-15 21:39 ` Tom Tromey
2014-01-16 17:02 ` Agovic, Sanimir
2014-01-16 17:33 ` Tom Tromey
2014-01-17 13:36 ` Agovic, Sanimir
2014-01-20 5:47 ` Tom Tromey
2014-01-20 9:32 ` Agovic, Sanimir
2013-12-17 12:19 ` [PATCH v4 08/13] vla: resolve dynamic bounds if value contents is a constant byte-sequence Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 13/13] test: add mi vla test Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 09/13] test: cover subranges with present DW_AT_count attribute Sanimir Agovic
2013-12-18 3:01 ` [PATCH v4 00/13] C99 variable length array support Joel Brobecker
2014-01-15 21:41 ` Tom Tromey
2014-01-16 17:05 ` Agovic, Sanimir
2014-01-16 22:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh49osy8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
--cc=palves@redhat.com \
--cc=sanimir.agovic@intel.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).