From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5264 invoked by alias); 16 Nov 2017 14:19:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4990 invoked by uid 89); 16 Nov 2017 14:19:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=phil, definite, letter, yours X-HELO: mail-wm0-f50.google.com Received: from mail-wm0-f50.google.com (HELO mail-wm0-f50.google.com) (74.125.82.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 14:19:10 +0000 Received: by mail-wm0-f50.google.com with SMTP id 70so366485wmf.1 for ; Thu, 16 Nov 2017 06:19:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GJx8TN8SJaPO+Fxp3feV1FGaZiHRmCSwQJAoOoLv9mc=; b=PeOb9a5tM9I5jM4p9B6dvVR3i1yYw8rT7n4EPkM797QgLDbEN+5scCP6kK2qWzrCeC 8ngNWnXYgzymgwrS/Oo12/eIawEhP3rgUS4ItFF1VZVpU5IIYSuuMOFcDfTlY8C1zoDn z4GcnBcZTutOprLbEYu8G6Gn3UhfB+9OOvPt+fwSoouSqERio+yEOnoU078ywm4T4+VT blJqaEehCcoRMg85x/xMtted4LsPcAqxtrhs5vYuTaw+5gFPaH9mtsblYR5tnSHS9Eip okG0e52Qcj7AIodjFQjlQLD08ninxU2JPgt6v2fbS1p/WD7TzjzGP7MZ7eGX1+NJ3ID/ hJqg== X-Gm-Message-State: AJaThX4m53+tV99gXpWES49MiaBzdAiGnCsS89emZmd3aOXb9fYrg9Sh sFny0RI4bPBdHzDq5PTroUq1hqdLTgs= X-Google-Smtp-Source: AGs4zMY5TW0rg4umcGFekse5TfUSXU8vII9cVpi/QbP0lOfgbHCV09tTo8zv53uhs9Ia4x272/rgfg== X-Received: by 10.80.227.138 with SMTP id b10mr2986809edm.16.1510841948228; Thu, 16 Nov 2017 06:19:08 -0800 (PST) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id c32sm1301262eda.57.2017.11.16.06.19.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Nov 2017 06:19:07 -0800 (PST) Subject: Re: [python][patch] Python rbreak To: Simon Marchi Cc: gdb-patches@sourceware.org References: <5e1ba7e3-5f6e-2478-30a5-7670ec7a9879@redhat.com> <3193f5c7a0c98c548722bb6c143f347e@polymtl.ca> <8ee8a4c0-4580-474f-a5aa-6f76a8d22960@redhat.com> <0cac20bb-f383-f83a-e621-99f425f225d6@ericsson.com> From: Phil Muldoon Message-ID: <87fc8f02-e7d5-0774-627f-b188ab668f74@redhat.com> Date: Thu, 16 Nov 2017 14:19:00 -0000 MIME-Version: 1.0 In-Reply-To: <0cac20bb-f383-f83a-e621-99f425f225d6@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00309.txt.bz2 On 14/11/17 20:22, Simon Marchi wrote: > On 2017-11-03 05:46 AM, Phil Muldoon wrote: >>>>> I can't find a reference, but I think we want test names to start >>>>> with a lower case letter and not end with a dot. I'll see if we >>>>> can add this to the testcase cookbook wiki page. >>>> >>>> As I mentioned on IRC, I've not heard of it but will happily change >>>> the names to comply. >> >> Sorry this took a bit longer to get back out than I would have liked. >> Modified patch follows. I believe I have incorporated yours, Eli's and >> Kevin's comments. ChangeLogs remain the same (other than the new NEWS >> entry which I have added locally.) > > Hi Phil, > > Sorry for the wait, I had missed the update. The patch looks good to me, > with just a nit below. > >> + if (obj_name == NULL) >> + return NULL; >> + >> + /* Is the object file still valid? */ >> + if (obj_name == Py_None) >> + continue; >> + >> + gdb::unique_xmalloc_ptr filename = >> + python_string_to_target_string (obj_name.get ()); >> + >> + if (filename == NULL) >> + return NULL; >> + >> + /* Make sure there is a definite place to store the value of >> + s before it is released. */ > > "of s" -> "of filename" ? > > Simon So committed, with that additional change. commit d8ae99a7b08e29e31446aee1e47e59943d7d9926 Thanks for the review Cheers Phil