Re: [PATCH] Fix AIX thread exit events not being reported and UI to show kernel thread ID.

[Tom Tromey <tom@tromey.com>]

>>>>> Aditya Kamath1 <Aditya.Kamath1@ibm.com> writes:

> Please find attached the patch. (See:
> 0001-Fix-AIX-thread-exit-events-not-being-reported-and-UI.patch)

Thanks for the patch.

> So, consider program 1 pasted below this email.

Is there some existing gdb test case that is fixed by this patch?  If
not then I think it would be better if the patch came with a new test.

I can't really comment on the AIX parts of the patch, but I noticed a
few little oddities.

>  static int
> -pcmp (const void *p1v, const void *p2v)
> +pcmp (struct pd_thread p1v, struct pd_thread p2v)
>  {
> -  struct pd_thread *p1 = (struct pd_thread *) p1v;
> -  struct pd_thread *p2 = (struct pd_thread *) p2v;
> -  return p1->pthid < p2->pthid ? -1 : p1->pthid > p2->pthid;
> +  return p1v.pthid < p2v.pthid;
>  }

Comparison functions passed to std::sort should return bool and
(ordinarily) use const reference parameter types.

Personally I'd probably just make this a lambda or maybe an operator<
but it's up to you.

>    pcount = 0;

Declaring this earlier and initializing it here is a bit strange now
that the logic has changed.

>    psize = 1;

This isn't needed any more, I think; and I'm surprised the compiler
didn't complain about it.

>    if (status == PTHDB_SUCCESS && detachstate == PDS_DETACHED)
>      /* i18n: Like "Thread-Id %d, [state] running, detached" */
> -    buf.printf (_(", detached"));
> +    buf.printf (_("[detached]"));
 
>    pthdb_pthread_cancelpend (data->pd_session, pdtid, &cancelpend);
>    if (status == PTHDB_SUCCESS && cancelpend)
>      /* i18n: Like "Thread-Id %d, [state] running, cancel pending" */
> -    buf.printf (_(", cancel pending"));
> +    buf.printf (_("[cancel pending]"));
 
The comments before these printfs are wrong now.

Tom