From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7657B3858C50 for ; Fri, 12 Apr 2024 22:32:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7657B3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7657B3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712961156; cv=none; b=cxsSPeOderUBMX+TxdKNITmHiIBStoamGsRYQS6owNpiuEj61dP708dQ5C2tR62ZGyurMDgc/OHp69triGN6nKe9jr8Api0t+7bkXPmpp2GczIgtMmITUIgsHd6iZvC7DC0is2BVEvMG2LrpaY38IIS817Ll53pQ3fHA2nIQJL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712961156; c=relaxed/simple; bh=XJzESk1uebbBHJGScEjuK48/MNIsKAF4Ncoh5sLkbm8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZlL8PdliV8zXv1LZuTSqfgJQHxvAGqUeANqZB9vFApebM3fC0++N8vzWMfhlFgunjiiIuRVl+4yav3ihdis+Cp0NTpy237F5wxbxVTRS2+0r3CKmEGmHqkZ7PzaD00S8ACm8E0iLmOb1f05DAxrlI4peQo97q/ZC+UVkJBhNfQQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712961153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wk6jqHAMqQ98MTj92TCKepkmJv6ijpI6qABXM6OsS6k=; b=aJ5Oc8tWB03lYjpgcWMFLrT6Nvx7EFgOzeAthIq7Tkd3D3dS8PCgQjZ95V7A0UhpKCAuCg PIeoZqcO/gNfgcgF1XQm8J/PViTsBpByaNloQIUNJEvRJ8w4Eo2SFtqghUZRSEqNAPkd2s VZMrIvoTwshceQ4p9HXr3j+I08IaQaY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-aPYG5gWhNGOOWnzyXKz6oQ-1; Fri, 12 Apr 2024 18:32:31 -0400 X-MC-Unique: aPYG5gWhNGOOWnzyXKz6oQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-416e58bdc0eso9296275e9.0 for ; Fri, 12 Apr 2024 15:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712961150; x=1713565950; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wk6jqHAMqQ98MTj92TCKepkmJv6ijpI6qABXM6OsS6k=; b=FSkEX00z13Sf44/P2nu7rywOI/1Y7LxcvITkEo1ys7H8hlUGL/PWYIJrb6YWcVaoy4 fjLTplXBJRTh26fO7o4Zow/vocoDSRsByLL5oGDf782TuGJ2AhYsr55p9x8SP17BjKHH 7+8EzRiOowx7YG7hP90XNQx+xCgN1I3qlfZtSzBDGBOI6xqQ+dlvDMQ1R3tlqKMAybqo vddCa934XuByKMElZL9hluq3ezTBObVtZdmyO5AyHuMGxAhbNIUH7aZLyQjkbxRRStm7 EXAVZf7yTTpWSNt5zufDzy8G7uCoKa9aJEALgbsBsm+YuJxzCt6nSsevchaYvmJUdKHU 3Zuw== X-Gm-Message-State: AOJu0YzAycU9/xUdl2hyxXw8H8bHV7ivMmfZ9hsdhMP6J5A4n6Dq9IFJ l4EhYw9RExyRXzo0iiIiToiPWj5B0y8TkZSR2qY7V3JVtChkHu/7Mun75Uy9+fTBELHsm85yUgi /1+urDQd50XwOEpb1v02CbTZXqDkB7b4c6Uve07+Ndue9jH1AzLQIpqNZ/pvB59AvKus= X-Received: by 2002:a05:600c:5493:b0:416:6e42:ecc5 with SMTP id iv19-20020a05600c549300b004166e42ecc5mr2753421wmb.40.1712961149675; Fri, 12 Apr 2024 15:32:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFATbbqJD0uwhMA7bMZtx4vGpj1drupDF/C3igV3ZXNu2kFv3WhVC75LOzV/4JuffkDHoj9Kg== X-Received: by 2002:a05:600c:5493:b0:416:6e42:ecc5 with SMTP id iv19-20020a05600c549300b004166e42ecc5mr2753414wmb.40.1712961149174; Fri, 12 Apr 2024 15:32:29 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c314f00b00417ee886977sm4636743wmo.4.2024.04.12.15.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 15:32:29 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/doc: use silent-rules.mk in the Makefile In-Reply-To: <868r1isaad.fsf@gnu.org> References: <09d4a16a33cf31f558a8982075800b113ed4a14e.1712940998.git.aburgess@redhat.com> <868r1isaad.fsf@gnu.org> Date: Fri, 12 Apr 2024 23:32:28 +0100 Message-ID: <87frvq43gj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Eli Zaretskii writes: >> From: Andrew Burgess >> Cc: Andrew Burgess >> Date: Fri, 12 Apr 2024 18:00:23 +0100 >> >> Make use of silent-rules.mk when building the GDB docs. >> >> Most of these are pretty straight forward, adding ECHO_GEN and then >> lots of SILENCE prefixes. >> >> I added a new SILENT_QUIET_FLAG to silent-rules.mk, this is like >> SILENT_FLAG, but is set to '-q' when in silent mode, this can be used >> with the 'dvips' and 'texi2dvi' commands, both of which use '-q' to >> mean: only report errors. >> >> As with the rest of the GDB makefiles, I've only converted the >> "generation" rules to use silent-rules.mk, the install / uninstall >> rules are left unchanged. >> >> There are still a few "generation" targets that produce output, there >> seems to be no flag to silence the 'tex' and 'pdftex' commands which >> some recipes use, I've not worried about these for now, e.g. the >> refcard.dvi and refcard.pdf targets still produce some output. >> >> Luckily, when doing a 'make all' in the gdb/ directory, we only build >> the info docs by default, and those rules are now nice and silent, so >> a complete GDB build is now looking nice and quiet by default. >> --- >> gdb/doc/Makefile.in | 158 ++++++++++++++++++++++++-------------------- >> gdb/silent-rules.mk | 1 + >> 2 files changed, 86 insertions(+), 73 deletions(-) > > Doesn't this silence too much? Can you should the output of each rule > after the changes? Yes you can. As with the rest of GDB, if you do: make all-gdb V=1 or make -C gdb/doc all-doc V=1 then you'll get everything back, just as it was before. For the commands that now get '-q' passed to them, the manual pages claim that errors will still be printed. So if something goes wrong you should still see the output required to fix the problem (without having to pass V=1). Some commands, like 'tex' and 'pdftex' don't have a -q option. In these cases I've not tried to silence the command as I assume any errors will arrive on stdout mixed in with the general noise. Thanks, Andrew