From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 6EA713858CDB for ; Tue, 19 Mar 2024 17:45:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EA713858CDB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6EA713858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710870360; cv=none; b=RQM//i3C5udPaCEpfwGayFfOYIvxRvDaAPBEQdfdnn3Cw9O4URa9iT7ttkU+1d9pPA7F4TW+TkzARJO+wwvRYhDu9YHxkvY57YgUTxNXBkI7Lmio6bfTLRG8+LWirshfDBXrOMKU8x141le7xGAEO0y/yI9ffxdiTBisV2bFqJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710870360; c=relaxed/simple; bh=+52go3BRtVVPshCOIt5DFtwfBMRiALOLpp0DuUDCUG8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=u808V3U822icBkLq+DJOZdCDeYoxJfBEeOjtNerDblNG7rSN+9G6L7lZGi6qJhW/xt/CKUUITek1X1MjfZjgfGl0omRmji8NQrTyoogD56hMkdeG8ksp1y8ViSttqnv6WIpXecl6CxJWJgmjURWO9998idOvW2PlInSo48JJ+DE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7cf005a80b5so26137739f.2 for ; Tue, 19 Mar 2024 10:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1710870358; x=1711475158; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=IDRVAc9uTvRw0LqnV5NxjWf3Y3Xa0R1C4nNqNv8dv9U=; b=FcbL0XSgU0Eaw7lG7I9HrOpapNzyc947Qd6oIvFEGN2cspQjepzAyylgZULTzi7XaV 46JJHHInZPErRNClHYCkRjb1Iuc23bs+htWEbM3UaUzOlMjZdsI/kpJcdqGZPNSpYRtC 0gSFch3we2Lxx/gjAPtTg4+jfEEh8PJYXedwq9PBNoKhu/OiV34J5tvdk1/DzCtNljA4 se5ydD0Zl1CZvZq0UgpJz0J4qGuAdfZIoEhMdT3H+8j4VZ9ufNvw91vyEF3NfCQilqrk GalZrCELPU7f3F5gwx925FfbOvF9cs5BeGWIPDqrbRG3ShurpzFOLCKk88jDXNvcTEk1 Ly2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710870358; x=1711475158; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IDRVAc9uTvRw0LqnV5NxjWf3Y3Xa0R1C4nNqNv8dv9U=; b=DqVOGnGyu8KghyV0nchulI5jDpZaIU9hkh7077fyXeTL8S+/CZmudrnSAmLAb0nQJ5 21GHWs0I/6Ze9krBpHKlH7tBOa+5VUfmbox0IKGB8c28CnftU9eLxAqYhAiO7NOtSBTH 3KlSRqcgKMO5Z1Od6IIgEhXazigrdgP+qMxPmvOzpBfEuogutHADtaDro+1/5fcX8Igf SKJLi52ypgX9x8vsXb7o14yGmGTvZJghHUaZvx/mnGzhc7g2jy07NH31/8ltI3H2CWH3 mhwWnDzx9qfzU3P3BnNQ21h6gb6a93QFpMMgaLgZnnPNNoqVyl7yYue8AiZGiyJzjN0r zQxg== X-Gm-Message-State: AOJu0Yw2oIeuL1/qaqlvYAK/zPf8imWpBnXjjO5QjDuvyAKkpTkHV372 xvpMDRXHaa88JLvgB0WS8LW2wFK+6d/gHweFkcA0HqiSZJ6hdmzPpk0WCz7log== X-Google-Smtp-Source: AGHT+IFkZBeDvdxWkmJ1o7yWb6jI47k0OyBH91iYCTQAXlpnMpCBp4VWx4Z0ZWKPK1K0oFm2CSbmtg== X-Received: by 2002:a5e:cb48:0:b0:7c8:92df:376e with SMTP id h8-20020a5ecb48000000b007c892df376emr3732840iok.5.1710870358693; Tue, 19 Mar 2024 10:45:58 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id a22-20020a027356000000b00479bd2d9ee0sm1524583jae.130.2024.03.19.10.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 10:45:58 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] Speed up lookup of "type_specific_data" References: <20240215160838.3999663-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 19 Mar 2024 11:45:58 -0600 In-Reply-To: <20240215160838.3999663-1-tromey@adacore.com> (Tom Tromey's message of "Thu, 15 Feb 2024 09:08:38 -0700") Message-ID: <87frwmglnt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> I noticed that "info locals" on a certain large Ada program was very Tom> slow. I tracked this down to ada_get_tsd_type expanding nearly every Tom> CU in the program. Tom> This patch fixes the problem by changing this code to use the more Tom> efficient lookup_transparent_type which, unlike the Ada-specific Tom> lookup functions, does not try to find all matching instances. I'm checking this in. Tom