From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id D11FC3858C66 for ; Fri, 23 Feb 2024 19:39:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D11FC3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D11FC3858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708717201; cv=none; b=huv7vlnteU4FpS3bwQFPajwc7xEBwIGG3+QDPbSL9LKy022VgEkoZyG7YogqDDrSoRE4JnHeIJTAghhR8fRLuHMxYwR/PU/49AIvAH59xhT8PHBTMMEzQ3d+lWfswwuRsN+BTZy0Yi6/sI5eU5KbpO6RFIyqwlo486JCYoxFbGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708717201; c=relaxed/simple; bh=GA2qX2dbCZNZlHtG3frIJS6ZazgJYO5u+CZhzEgJOWc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lcAzSMH4CrdtDZdEMIdtVb1UWiD7WDEzxIx9P58iu4TO6xVciyIK7nz0T55ISdYRUzLvH9uipHO8oQVXc3nMj0K4WwhklBi5euEMdFma3dEvnnXSiJ2kM/Yh2/oqgKkadkkIAHmSQMmpnMPwEv1k2Q49D/UfX5/cl/X9+cbRNbk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-3650dcd38a0so2030465ab.1 for ; Fri, 23 Feb 2024 11:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1708717199; x=1709321999; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GA2qX2dbCZNZlHtG3frIJS6ZazgJYO5u+CZhzEgJOWc=; b=DTPRYnzjVbf/ICWDkDWhR+fgSJWiCjgB7nbzCtCjUuw1zW9OaS31V1kV2Mg2wszbU6 R9fyRstrabUpOIuqSISwDEMg+Q7J8w/Nue3qIKznomX+ZlIgK8bcrIFgel+RhD6qRUNB O3f+6sXUFk8mvbZyI8drUrCjSCav2UMT+Pf/NCYiL50jGsfoB6JbZgjHzU/eABk/Mx7O VfrXxRwca3lEMHZ8p7/NxsdvduNBLYS9jlgE9F8bSM5P4RwIaokEzKPCbLjMBFoTMgjR HaQO2Hq77H+AcJESp0xwvhwf+Nj663vAk8cg0oDSXd3wnLcgwjpRa4u+5bGcybK/28Ti C79Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708717199; x=1709321999; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GA2qX2dbCZNZlHtG3frIJS6ZazgJYO5u+CZhzEgJOWc=; b=vcBEl6qieHHP3s2+GfZkStQ0ovSTYp7OR3sryktFxNRqfNijbtKktx1Ccve/LJrUhs ROWyN0lX0UfY6HOfvnl6uOMOsTNJKf4gAHhw5m4EpSCm3043w/62slfGy87OxUIH1rDp gTwO/3RLoJ7RFjTBerbDhI6P80d7MM3BvEeOneDRY5h3Md1BcqG/JwaqkCKQgvrZv9BJ il5AgmcSqo4Sgwezu5+5nunzHGr5/Pg6KQi+RtRAZsSub+9LKFHnkLg0Rw8qwM+VeZfH ivNol2ZzKRL6DUik4+NzhQHQwW91DdeyWQsXOPBnd+TD/3vDqEJWTxMZT9GyFj659AvO EAtw== X-Forwarded-Encrypted: i=1; AJvYcCUHfWJJlNtxbRlfGGPfHG0DiC4IuVbefBId2Fmgpzown5q7MdLj29pycXf35L4xEiAAF1bIfM7LvxpGpXRMLyhp+8cgBUKWngVJNQ== X-Gm-Message-State: AOJu0YztlmGSe/aQmOR81igfIikLPCh3UDLsv9KoBhE3cPfUEUnb3Rd3 gzIz0qguCzkBWpb/rlbk5a995BDHQMenh7UUH4q5KZYkAn2gYZ7omxwB+PAtEP8TvsKwI6Hy4AU = X-Google-Smtp-Source: AGHT+IFM6uNaiUmZmDW7S+HhVTOUUHYx9gDVRKFSTeLf8YDUuPaaJFl1Z5THeMNN7KB3fPcCT+Gu2Q== X-Received: by 2002:a05:6e02:552:b0:365:f8d:50c3 with SMTP id i18-20020a056e02055200b003650f8d50c3mr852021ils.21.1708717199007; Fri, 23 Feb 2024 11:39:59 -0800 (PST) Received: from murgatroyd (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id bo33-20020a056e02342100b00363c90b1207sm602057ilb.55.2024.02.23.11.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 11:39:58 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix two minor flake8 issues References: <20240223190145.3629627-1-tromey@adacore.com> <89af7e7a-f792-40a4-a6c2-89902ffc5380@simark.ca> X-Attribution: Tom Date: Fri, 23 Feb 2024 12:39:58 -0700 In-Reply-To: <89af7e7a-f792-40a4-a6c2-89902ffc5380@simark.ca> (Simon Marchi's message of "Fri, 23 Feb 2024 14:33:08 -0500") Message-ID: <87frxjx94h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> If we change these, black is going to immediately want to revert them. lol I forgot about this. Simon> I propose to just add this in gdb/.flake8 or gdb/setup.cfg, as the page Simon> suggests: Simon> [flake8] Simon> max-line-length = 88 Simon> extend-ignore = E203,E701 Please do. Internally I see we use: # See # https://github.com/psf/black/blob/master/docs/compatible_configs.md#black-compatible-configurations # to understand the max-line-length and extend-ignore settings. max-line-length = 88 extend-ignore: E203, W503, B906, B907 I don't remember what these other ones are about. Tom