From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 4A5DE3858D33 for ; Fri, 22 Dec 2023 16:51:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A5DE3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A5DE3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703263873; cv=none; b=cMZ180wdkcrTeTDXRVuQ47xDu50Qc/UQudkXAow/9XkObLdYe8dS4QC3ccQrQM74sV+bmx+dBvrTvyONJBlISvaRZGQZiS6qeJuc9QIeH8nYnz0+LLR9nPkpQILumX4a+fts/TTf/5Xxhp/pbsU+wPB4RVc0pv2c0UnQBu+GYo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703263873; c=relaxed/simple; bh=7zwkqbQYYhvFak3xNDzuavqNjSbKlFoOHIr8d8UKUng=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nG57JfbhODzlFypv9XyLNsmzWjs5dDTr1CyJmLdEw/wVTdA+9Cvg/Qv1WlLrTryWd61GtfNwa0WQRxrOE/EZtjBRnrLkt45iKD670+mmQTvJjn9hku7si4Z1rcTCWX1bOYms0UZb9ZyzRXqrQm9fh2Sk4lIvoKuVR7X2BAqsYMo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id GfqvrORYyWcCIGijvrB4st; Fri, 22 Dec 2023 16:51:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id GijtriNCM11XZGijur9a63; Fri, 22 Dec 2023 16:51:10 +0000 X-Authority-Analysis: v=2.4 cv=Z+v/oVdA c=1 sm=1 tr=0 ts=6585be7e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=7d_E57ReAAAA:8 a=HQTrVD5z_ahf3P7-RDUA:9 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aBeHxZaEvw0MiTaedA7QFV3eozcmRkBAjS5Ppd/Aq8E=; b=Sf2TzDjdlb5ATyL1AKDsKs05Lr XnpIhd8M/fv+Ob8XKCdI1A+4+jXEotsn09nEtUmXR78S+mKwnulLmWzj950L9daNJn4TwnunP84Kl XVz0smDzxkGbRgM8o8uou1cXl; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:58022 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rGijt-003N6Q-1W; Fri, 22 Dec 2023 09:51:09 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 7/9] gdb: remove VALUE_NEXT_FRAME_ID, add value::next_frame_id References: <20231221191716.257256-1-simon.marchi@efficios.com> <20231221191716.257256-8-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 22 Dec 2023 09:51:08 -0700 In-Reply-To: <20231221191716.257256-8-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 21 Dec 2023 14:16:28 -0500") Message-ID: <87frzu18qr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rGijt-003N6Q-1W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:58022 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfH8WW/RMkPVKbw0cTG53bRLOjTfJnpvxcMBPq+pEHfc7IPPcltixiysR+tTgVwJovDIfcgE3kTi6V3EkTah4SS03nxmQxKU7tUga3DethiKY7IcvlI9N XHXYKnIRIZ/+ypEie72PsQtLSou9uB0SPUrhL6CTnmQr7Qnq9sgpMat0nb9KgOelmaN3PpXOOvsQCj7AsijRIlh1u/r1I0s4bq0= X-Spam-Status: No, score=-3016.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> Remove VALUE_NEXT_FRAME_ID, replace it with a method on struct value. Set Simon> `m_location.reg.next_frame_id` directly from value::allocate_register_lazy, Simon> which is fine because allocate_register_lazy is a static creation Simon> function for struct value. I looks like every user except value::fetch_lazy_register actually immediatley calls find_frame_by_id with the result; so I wonder if this should just return a frame_info_ptr instead. BTW thank you for doing this, I'm happy to see VALUE_NEXT_FRAME_ID go away. Tom