From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 437F73858C52 for ; Fri, 15 Dec 2023 20:08:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 437F73858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 437F73858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702670901; cv=none; b=Trw7dwpGmOr+VhmONWPxrGrlXAR5RDV1zBR/8rxLUBTtdEs2K7/3J8uRTJS3uPf2FGeEbZvc50ZtzYoiT0bMKU3FxBK6MsY8oPN+5ANSN3jkW7C5u499i+8gVCqrTjC4Phfraz++aaCmJ08vAQDDsV2kzqjaipOwEiF7fLqm8xk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702670901; c=relaxed/simple; bh=BaSP4zG6bPKqAlhMknLAA5RTQ/irt7kOomFQkI4/Jxg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RilUFHOaA70Pht0tQY5DfyFf7/5dSYycQ//DqvY7ywb925eC0FKaHROva3Pln5f170otEHGBDrX8K6pcnBrkkNoc5UQNd3KvIXTfWRwtwv7phKtNoDMsvpYPipgd4O/x6C9INm6Wubv5ntir2vGvXq+1zvbZt0bj0zReS/0mvZo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id EAuHrsDSGWcCIEETrrFgZT; Fri, 15 Dec 2023 20:08:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id EETqrwqi91b9NEETqr6ciZ; Fri, 15 Dec 2023 20:08:18 +0000 X-Authority-Analysis: v=2.4 cv=FLYIesks c=1 sm=1 tr=0 ts=657cb232 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=yQ62M5NqOEjU-G9U7WoA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=c7JCtZzjsSivmBTKE4IedyK3zQjK7O3pcAI5n8A1o6M=; b=x/A8WZEyn9EScZk8X9NJn4o5Rs CmC4bslKIhPogezwZi0sMITPDA3k9ZxoZtVdDEjiC7qT+ATi74r8enkkDVVP8ChZvaILJDtSru30E k3IRisBpXCJ6o0IbUBz1A1741; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:60122 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rEETp-003lgj-2Z; Fri, 15 Dec 2023 13:08:17 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv7 02/11] gdb: create_breakpoint: asserts relating to extra_string/parse_extra References: <93c524c752f2c3ccf55edc4c8b4aa8839395fd9b.1702507015.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 15 Dec 2023 13:08:17 -0700 In-Reply-To: <93c524c752f2c3ccf55edc4c8b4aa8839395fd9b.1702507015.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 13 Dec 2023 22:38:26 +0000") Message-ID: <87fs035ivi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rEETp-003lgj-2Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:60122 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHAXKASVVUCw2qgWrvPD9pUyoCYpOG1+ybEYeN6kpfo6NW6n8F2qmoR5ONI5nmYSQju1lYXqNdvsMYiVqlrCsTeHCWRpSerOKiGz4qhMb6IbekA5ZLbE 2GuvYdnkUergRVLJoERxTxr39/c4ZLJQOiRz6FYRuOisg3PiQsdNwM5jsmgETfXhQ24aWOcUPcDZmNlcEi9q2FPeB/NqDiIcClg= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit makes one possibly breaking change: until this commit it Andrew> was possible to create thread-specific dprintf breakpoint like this: Andrew> (gdb) dprintf call_me, thread 1 "%s", "hello" Andrew> Dprintf 2 at 0x401152: file /tmp/hello.c, line 8. Andrew> (gdb) info breakpoints Andrew> Num Type Disp Enb Address What Andrew> 2 dprintf keep y 0x0000000000401152 in call_me at /tmp/hello.c:8 thread 1 Andrew> stop only in thread 1 Andrew> printf "%s", "hello" Andrew> (gdb) Andrew> This feature of dprintf was not documented, was not tested, and is Andrew> slightly different in syntax to how we create thread specific Andrew> breakpoints and/or watchpoints -- the thread condition appears after Andrew> the first ','. Andrew> I believe that this worked at all was simply by luck. We happen to Andrew> pass the parse_extra flag as true from dprintf_command to Andrew> create_breakpoint. FWIW, I agree, this is just an accident of the implementation and not something we should continue to support. Tom