From: Tom Tromey <tom@tromey.com>
To: Mohamed Bouhaouel <mohamed.bouhaouel@intel.com>
Cc: gdb-patches@sourceware.org, blarsen@redhat.com, eliz@gnu.org
Subject: Re: [PATCH v3 2/3] gdb, breakpoint: add a breakpoint type converter
Date: Tue, 14 Nov 2023 07:37:17 -0700 [thread overview]
Message-ID: <87fs18qu3m.fsf@tromey.com> (raw)
In-Reply-To: <20231114133532.3877-3-mohamed.bouhaouel@intel.com> (Mohamed Bouhaouel's message of "Tue, 14 Nov 2023 14:35:31 +0100")
>>>>> Mohamed Bouhaouel <mohamed.bouhaouel@intel.com> writes:
> Add a new function 'bptype_to_target_hw_bp_type' to perform
> the translation from 'bptype' to 'target_hw_bp_type'.
Thank you.
> +target_hw_bp_type
> +bptype_to_target_hw_bp_type (bptype type)
> +{
> + default:
> + error (_ ("Bad breakpoint type: bptype %d."), type);
Can this ever be reached? If not it should be gdb_assert_not_reached.
If so then it should have a better error message -- this one won't make
sense to users.
> +/* Translate BPTYPE to TARGET_HW_BP_TYPE. */
> +
> +extern target_hw_bp_type bptype_to_target_hw_bp_type (bptype type);
> #endif /* !defined (BREAKPOINT_H) */
Newline before #endif
Tom
next prev parent reply other threads:[~2023-11-14 14:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 13:35 [PATCH v3 0/3] Check for zpoint support when handling watchpoints Mohamed Bouhaouel
2023-11-14 13:35 ` [PATCH v3 1/3] gdb, gdbserver, zpoint: report z_point support Mohamed Bouhaouel
2023-11-14 13:45 ` Eli Zaretskii
2023-11-14 14:36 ` Tom Tromey
2023-11-15 17:31 ` Bouhaouel, Mohamed
2023-11-14 13:35 ` [PATCH v3 2/3] gdb, breakpoint: add a breakpoint type converter Mohamed Bouhaouel
2023-11-14 14:37 ` Tom Tromey [this message]
2023-11-15 17:44 ` Bouhaouel, Mohamed
2023-11-14 13:35 ` [PATCH v3 3/3] gdb, zpoint: check for target hardware breakpoint support Mohamed Bouhaouel
2023-11-14 14:45 ` Tom Tromey
2023-11-15 18:18 ` Bouhaouel, Mohamed
2023-11-17 13:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs18qu3m.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mohamed.bouhaouel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).