From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta39.uswest2.a.cloudfilter.net (omta39.uswest2.a.cloudfilter.net [35.89.44.38]) by sourceware.org (Postfix) with ESMTPS id BADF73858D28 for ; Tue, 22 Aug 2023 15:34:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BADF73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTP id YEgUqtcFLbK1VYTOMqYKTG; Tue, 22 Aug 2023 15:34:02 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id YTOKqUVu6gfmkYTOLqHpGx; Tue, 22 Aug 2023 15:34:01 +0000 X-Authority-Analysis: v=2.4 cv=e/wV9Il/ c=1 sm=1 tr=0 ts=64e4d569 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=0NUow8alPA-d0ezkIl0A:9 a=zZCYzV9kfG8A:10 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UeGvMgdlUU5EwOZC7Lq7bGjagyI206wCE7Kpq0lw3e4=; b=a6OVsn+j0XXHVTTmvABZDZfsU8 VWfgKtwqmtEa9CBX4ikUMy0yKMALYMz7fid7kLRiiPj/YnjFDH4xa6UHZi58CMmjScYjK6CqisdjN k34HV55UmwiF4z7q4QKetubbq; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:54714 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qYTOK-003ZsU-1G; Tue, 22 Aug 2023 09:34:00 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess , Tom Tromey Subject: Re: [PATCH 0/3] New gdb::make_unique and more std::unique_ptr use References: X-Attribution: Tom Date: Tue, 22 Aug 2023 09:33:59 -0600 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Mon, 14 Aug 2023 14:42:31 +0100") Message-ID: <87fs4bw0pk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qYTOK-003ZsU-1G X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:54714 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFmNnHf+iepTYnrA5AzCtv80U/Jgen4DiI1VgjK99RDdjvUthDtDch+2jub1sm5ZsqiOI5wm2nawZHz82118N7nZBUkANxDeLEiLUMQgTNxpES5GHUrp b9WE1jmSjn9IcUIeXOoXkdrRi+JOTmxJC1DPrJddeqqpJoyi/GLXuTkeAq05ry+QuU9BCXEihd39Ass4xeUD0eSykmY+8mjx10I= X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> This started while working on another series, in order to avoid Andrew> calling 'new' directly, I really wanted a std::make_unique function -- Andrew> but that's C++14, so not available for GDB right now. Andrew> So I added a gdb::make_unique, which should be equivalent to the C++14 Andrew> function. Andrew> The last two commits are additional make_unique/unique_ptr changes, Andrew> but target specific areas that needed slightly more refactoring. Thanks for doing this. I re-read the series & with your latest make_unique patch, it looks good to me. FWIW I think the ::make approach was just a sort of minimal refactoring at the time. Previously the constructor didn't do anything. Approved-By: Tom Tromey Tom