From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 1C672385624C for ; Thu, 17 Aug 2023 18:07:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C672385624C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-79196067c75so1911739f.1 for ; Thu, 17 Aug 2023 11:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1692295638; x=1692900438; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lg5RDHGoSPHlQwHXvHDQl/6ZpOsLZyTdksHAfsgKMSE=; b=WV9KLhvTCFXtlj3YEDpe9gZewf9+FYcInsq+Yo+kYwaEaaeGzavJkQ6zGsVTHEY5Fk pXQkLX7n9UU07w6KursiUPZyBmR4epolKfCSSiTKHqhHS+tY8Pzt0aMat9z/f6tU9vUU hwH5tfQWmyv8iWEKXRcQtAWZ9cSoAgtoG5knmZt+1+BU3hVZF/LEdzkBO+1vIjuANBmM 1Tbloz7q81WUBp2QZV3CoQmS3tNsq1NU4fErPZXyx+BlensXqapMIaP1fVxoxhwlwEI4 tTGcxM9OcXttpiYf9kq8h/Uz5faE6Q+iwJYsmbFQ4ee4lOtpUcKaC8s1mpdS3B/UUP2x cLAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692295638; x=1692900438; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lg5RDHGoSPHlQwHXvHDQl/6ZpOsLZyTdksHAfsgKMSE=; b=danB/1Nq0ocHyDLx6uAxYCglBKaUQzJrun0ZmCM5qQF0bf9QiBLEgWNcO5fiDPYmTO gGnXVVFDeNY9tYdpjhPoBzahrj5ZMIlgw3u8Nek6b+QPKmPQ9H5n+Vt1n3ijpvcy0rR3 gci5Ody3JHMaNlR133sD4Cj4T2QLoLYl2BQjNWhvyfcBr/dainMMvP8sLYdT3u42VzOK JC9t2wdvBqwVOmR+C3muuMJ7LcdVEJs+obZvQ5WqW9NrcFY7pij9BgfCBOOhSF0hj8Yl Q+HJ3rEl7X1Ptoe0+SHOy//yefdgFLd91rSYZMcsou/KCUqjTH8xs/dNNPQ0vgZ2m/S8 IMEg== X-Gm-Message-State: AOJu0YymKAED3ZXYiB8ylXj4CIVZTEYqaPbeoV9NlgyvY5rvilOmSw9N c755vyZDtFQPNLG8V7+vnGhYBw== X-Google-Smtp-Source: AGHT+IHEKz0nfsiVm5EzrXdXWeRJCcKgp+QprG6Dp9Aj+xhjVAWxpUvZA7/MqiOkNl79ZIOcMrjZCw== X-Received: by 2002:a05:6602:2243:b0:790:a211:b95a with SMTP id o3-20020a056602224300b00790a211b95amr456093ioo.4.1692295638297; Thu, 17 Aug 2023 11:07:18 -0700 (PDT) Received: from murgatroyd (75-166-142-177.hlrn.qwest.net. [75.166.142.177]) by smtp.gmail.com with ESMTPSA id g6-20020a02b706000000b0041d73d0a412sm5135705jam.19.2023.08.17.11.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 11:07:17 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdb: add gdb::make_unique function References: <874jl11vnu.fsf@tromey.com> <87zg2qarrk.fsf@redhat.com> X-Attribution: Tom Date: Thu, 17 Aug 2023 12:07:16 -0600 In-Reply-To: <87zg2qarrk.fsf@redhat.com> (Andrew Burgess's message of "Thu, 17 Aug 2023 11:26:55 +0100") Message-ID: <87fs4hy23v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> I couldn't figure out a way to truly 'alias' gdb::make_unique to Andrew> std::make_unique. Yeah, sorry about that. I confused this with type aliases. Andrew> I figure that at some point GDB will move off C++11, at which time it's Andrew> easy enough to globally: s/gdb::make_unique/std::make_unique/. Yep. Andrew> +template Andrew> +std::unique_ptr Andrew> +make_unique (Arg... args) I think it's more idiomatic to use 'Arg &&...args' here. Tom