From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 5D5683858D1E for ; Wed, 2 Aug 2023 19:37:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D5683858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-1a28de15c8aso66492fac.2 for ; Wed, 02 Aug 2023 12:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1691005029; x=1691609829; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0pUH3x2KgeIPE/8N3sPJKERADfVn4vYH5uIDcsg4NUU=; b=ZDfl2prKhYd7B5sVa1KzFllhvtM/fVn9i65jJu94RwHQDRwGmZTQHD7o9911p9Emxy NTbDiYWAgTkSz7DvLV54soKzTkHOwCW8844E0IUxkNXKGB+T6MIL1DDa7jFZZ51ID8PV I2Nl8hCs5RQkhkWIbzXxC86pG8B9w8fasE9WEgMJngAC/4YSDe/i8MVQ1QaHWPciSlvq Ujo0j7c2XqQPpa/sdrvjOMJ6SC1v48Y1d9xqBY/VNqwwDpgVqXM5jOUawbwgzLdFN+85 lh/zWzSsDWC+nevLp/V0g5Tvdv3qq56xgWI599cDrBtkMYT6gzItriQGmV6080wi8Zuk NDow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691005029; x=1691609829; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0pUH3x2KgeIPE/8N3sPJKERADfVn4vYH5uIDcsg4NUU=; b=OfuXnWytQd9geU1gc7k11TvNSp2JrM8kn5sQjp8smfj8EL+E7oNSeac/sFjpqSPNft zClwBkkagDILRHET5chsKZzepxnYV/f6dKtDKUfd2wGFZ1b3IwPZuBLDCpg962gTxlR1 kD+IA1rg0E61CGMuDUTDGAfnKHkay2I7FYiCxup8ZNnE7CstTr1l2KoDlycO8uh2EUdo eow2yfR/0h68hqCwu6zQ/HJzrgohNbNPjx6P2bjF1FJiu0zBTDA/fUYY9jtnAdBAwDjm W2T+4s3KrXe+RBsOzTrSTtd5X2+AdeniQcMhc0Cbt8Cj7yKp3p9EpOcY4aYdO3ELPDX5 sakw== X-Gm-Message-State: ABy/qLaFr/cbXoKePrmk5xptVcN9aejNmf0X0+wbFLey++W5IH0EMRGw fPziH7Zv1VtuxIoPwffwRFfcMDcc0eRLVQxLccQlXw== X-Google-Smtp-Source: APBJJlEZuL/kcNSqeg3Lssm14vBzza+MVqZoCTgRdIb3wdNNzKZ616Vbpq3sGm1oMMUJBxDc7rcFyA== X-Received: by 2002:a05:6870:b50e:b0:1b0:12d7:1ef6 with SMTP id v14-20020a056870b50e00b001b012d71ef6mr18803851oap.25.1691005029651; Wed, 02 Aug 2023 12:37:09 -0700 (PDT) Received: from murgatroyd (75-166-148-59.hlrn.qwest.net. [75.166.148.59]) by smtp.gmail.com with ESMTPSA id i20-20020a02c614000000b0041ab9b6f5b0sm4584137jan.128.2023.08.02.12.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 12:37:09 -0700 (PDT) From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH v2 4/6] [gdb/symtab] Fix data race on bfd_last_cache References: <20230802095305.3668-1-tdevries@suse.de> <20230802095305.3668-5-tdevries@suse.de> X-Attribution: Tom Date: Wed, 02 Aug 2023 13:37:08 -0600 In-Reply-To: <20230802095305.3668-5-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 2 Aug 2023 11:53:03 +0200") Message-ID: <87fs51dymz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> The race is between: Tom> - a worker thread calling main_name (), and in the process reading Tom> bfd_last_cache, and Tom> - the main thread writing to bfd_last_cache. Tom> Fix this by calling main_name () from the main thread. It seems to me that index-write.c should not be calling main_name. main_name might iterate over objfiles, but writing when writing an index for a specific objfile, only that objfile's notion of "main" should be considered. Instead maybe this code can just query the cooked index directly. Tom